[Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin by nreese · Pull Request #90292 · elastic/kibana

nreese · 2021-02-04T16:10:18Z

#89225 renamed the old file_upload to maps_file_upload to clear the file_upload namespace
#89640 moved ml import API endpoint into the new file_upload plugin

This PR finishes the creating of a unified file_upload plugin by folding maps_file_upload public folder into the new file_upload plugin and removing maps_file_upload plugin.

elasticmachine · 2021-02-04T16:10:21Z

Pinging @elastic/kibana-gis (Team:Geo)

jbudz

optimizer limits LGTM

edit: failure related to the maps plugin limit

spalger · 2021-02-04T22:16:41Z

jenkins test this

kindsun

Overall, works really well! This is a great step forward towards a unified file upload presence. I'm not seeing any differences in how this operates w/ the new back-end, which is super. Didn't see any residual dangling references that need to be updated. lgtm w/ green CI!

code review
tested locally in chrome

nreese · 2021-02-05T02:00:44Z

x-pack/test/functional/apps/maps/import_geojson/file_indexing_panel.js

      expect(newIndexedLayerExists).to.be(false);
    });

-    it('should create a link to new index in management', async () => {


Removed test case because /app/management/kibana/indexPatterns URL no longer supports filter option.

peteharverson

ML edits LGTM

x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json

Bamieh

LGTM

nreese · 2021-02-06T13:59:03Z

@elasticmachine merge upstream

kibanamachine · 2021-02-09T23:45:01Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fileUpload`	-	189	+189
`mapsFileUpload`	187	-	-187
`ml`	1735	1732	-3
total			-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fileUpload`	-	825.2KB	⚠️ +825.2KB
`mapsFileUpload`	825.8KB	-	-825.8KB
`ml`	6.3MB	6.3MB	-2.0KB
total			-2.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fileUpload`	-	10.4KB	+10.4KB
`maps`	139.0KB	139.0KB	-4.0B
`mapsFileUpload`	7.2KB	-	-7.2KB
`ml`	58.0KB	58.2KB	+237.0B
total			+3.5KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`file-upload-telemetry`	2	-	-2

Unknown metric groups

async chunk count

id	before	after	diff
`fileUpload`	-	1	+1
`mapsFileUpload`	1	-	-1
total			-0

History

💔 Build #104510 failed 49588ab
💚 Build #104236 succeeded 0b06e82
💔 Build #104124 failed 251bbe8
💔 Build #104031 failed 3bf8d22
💔 Build #103979 failed 797ecb4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…e_upload plugin (elastic#90292) * get geojson working with api/file_upload/import * remove maps_file_upload server code * remove common folder * remove maps_file_upload plugin * fix tsconfig paths * rename file_upload plugin in maps tsconfig * fix file path * node scripts/build_plugin_list_docs * fix webpack compile errors * telemetry schema cleanup, i18n cleanup, limits cleanup * remove mapsFileUpload from limits.yml * remove index pattern link test case * update telemetry/v2/clusters/_stats for new file_upload path Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…e_upload plugin (#90292) (#90890) * get geojson working with api/file_upload/import * remove maps_file_upload server code * remove common folder * remove maps_file_upload plugin * fix tsconfig paths * rename file_upload plugin in maps tsconfig * fix file path * node scripts/build_plugin_list_docs * fix webpack compile errors * telemetry schema cleanup, i18n cleanup, limits cleanup * remove mapsFileUpload from limits.yml * remove index pattern link test case * update telemetry/v2/clusters/_stats for new file_upload path Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (99 commits) [Fleet] Use Fleet Server indices in the search bar (elastic#90835) [Search Sessions] added an info flyout to session management (elastic#90559) [ILM] Revisit searchable snapshot field after new redesign (elastic#90793) [Alerting] License Errors on Alert List View (elastic#89920) RFC Improve saved object migrations algorithm (elastic#84333) [Lens] (Accessibility) Fix focus on drag and drop actions (elastic#90561) Use new shortcut links to Fleet discuss forums. (elastic#90786) Do not generate an ephemeral encryption key in production. (elastic#81511) [Fleet] Use staging registry for snapshot builds (elastic#90327) Actually deleting x-pack/tsconfig.refs.json (elastic#90898) Add deprecation warning to all Beats CM pages. (elastic#90741) skip flaky suite (elastic#90136) Revert "Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)"" (elastic#90889) remove ref to removed tsconfig file [core.logging] Uses host timezone as default (elastic#90368) [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (elastic#90292) Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)" [dev-utils/ci-stats] support disabling ship errors (elastic#90851) Prefix with / (elastic#90836) [Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244) ...

…into file_upload plugin (#90292) (#90890)" This reverts commit bd81ff9.

tylersmalley · 2021-02-10T14:12:45Z

@nreese I reverted the 7.x backport due to it breaking CI.

1226842

I believe it to be an incompatibility with #90537

…e_upload plugin (elastic#90292) * get geojson working with api/file_upload/import * remove maps_file_upload server code * remove common folder * remove maps_file_upload plugin * fix tsconfig paths * rename file_upload plugin in maps tsconfig * fix file path * node scripts/build_plugin_list_docs * fix webpack compile errors * telemetry schema cleanup, i18n cleanup, limits cleanup * remove mapsFileUpload from limits.yml * remove index pattern link test case * update telemetry/v2/clusters/_stats for new file_upload path Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…to file_upload plugin (#90292) (#90946) * [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (#90292) * get geojson working with api/file_upload/import * remove maps_file_upload server code * remove common folder * remove maps_file_upload plugin * fix tsconfig paths * rename file_upload plugin in maps tsconfig * fix file path * node scripts/build_plugin_list_docs * fix webpack compile errors * telemetry schema cleanup, i18n cleanup, limits cleanup * remove mapsFileUpload from limits.yml * remove index pattern link test case * update telemetry/v2/clusters/_stats for new file_upload path Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * remove maps_file_upload from tsconfig.refs.json * remove x-pack/tsconfig.refs.json, removed in upstream Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

nreese added 4 commits February 4, 2021 08:45

get geojson working with api/file_upload/import

f1e3c4c

remove maps_file_upload server code

bfa1664

remove common folder

f25339c

remove maps_file_upload plugin

184cd84

nreese added chore Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 4, 2021

nreese requested a review from kindsun February 4, 2021 16:10

nreese added 5 commits February 4, 2021 09:26

fix tsconfig paths

0046da1

rename file_upload plugin in maps tsconfig

3686a0c

fix file path

bd26675

node scripts/build_plugin_list_docs

a018b3c

fix webpack compile errors

cd37a99

nreese requested a review from a team as a code owner February 4, 2021 19:19

telemetry schema cleanup, i18n cleanup, limits cleanup

797ecb4

nreese requested review from a team as code owners February 4, 2021 20:10

jbudz approved these changes Feb 4, 2021

View reviewed changes

remove mapsFileUpload from limits.yml

3bf8d22

kindsun approved these changes Feb 4, 2021

View reviewed changes

remove index pattern link test case

251bbe8

nreese requested a review from a team as a code owner February 5, 2021 01:59

nreese commented Feb 5, 2021

View reviewed changes

peteharverson approved these changes Feb 5, 2021

View reviewed changes

Bamieh reviewed Feb 5, 2021

View reviewed changes

x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json Show resolved Hide resolved

nreese requested a review from Bamieh February 5, 2021 13:41

update telemetry/v2/clusters/_stats for new file_upload path

0b06e82

Bamieh approved these changes Feb 6, 2021

View reviewed changes

Merge branch 'master' into remove_maps_file_upload

49588ab

This was referenced Feb 7, 2021

[ml] remove ml:canFindFileStructure access tag from file_upload/import route #90557

Closed

[ml] switch import route tag from access:ml:canFindFileStructure to access:fileUpload:import #90677

Merged

merge with master

cb4672b

nreese merged commit 1ba7d7a into elastic:master Feb 10, 2021

nreese mentioned this pull request Feb 10, 2021

[7.x] [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (#90292) #90890

Merged

tylersmalley added a commit that referenced this pull request Feb 10, 2021

Revert "[Maps] remove maps_file_upload plugin and fold public folder …

1226842

…into file_upload plugin (#90292) (#90890)" This reverts commit bd81ff9.

nreese mentioned this pull request Feb 10, 2021

[7.x] [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (#90292) #90946

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin#90292

[Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin#90292
nreese merged 15 commits intoelastic:masterfrom
nreese:remove_maps_file_upload

nreese commented Feb 4, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Feb 4, 2021

Uh oh!

jbudz left a comment •

edited

Loading

Uh oh!

spalger commented Feb 4, 2021

Uh oh!

kindsun left a comment

Uh oh!

nreese Feb 5, 2021

Uh oh!

peteharverson left a comment

Uh oh!

Uh oh!

Bamieh left a comment

Uh oh!

nreese commented Feb 6, 2021

Uh oh!

kibanamachine commented Feb 9, 2021

async chunk count

Uh oh!

tylersmalley commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

nreese commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Feb 4, 2021

Uh oh!

jbudz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalger commented Feb 4, 2021

Uh oh!

kindsun left a comment

Choose a reason for hiding this comment

Uh oh!

nreese Feb 5, 2021

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

nreese commented Feb 6, 2021

Uh oh!

kibanamachine commented Feb 9, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

Saved Objects .kibana field count

async chunk count

History

Uh oh!

tylersmalley commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nreese commented Feb 4, 2021 •

edited

Loading

jbudz left a comment •

edited

Loading