[Fleet] Use staging registry for snapshot builds by ruflin · Pull Request #90327 · elastic/kibana

ruflin · 2021-02-04T20:07:13Z

The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with -SNAPSHOT not the master branch will use the staging registry.

Closes #90131

The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with `-SNAPSHOT` not the master branch will use the staging registry. Closes #90131

ruflin · 2021-02-04T20:10:22Z

@skh I'm struggling a bit with testing this. I tried to modify the package.json and adjust version / branch but this had many unexpected side effects as the values are also used in other places. I maybe have to cherry pick it to the 7.x branch for testing. But then I still miss -SNAPSHOT in the version.

spalger · 2021-02-04T22:18:09Z

jenkins test this

skh · 2021-02-08T13:54:35Z

I maybe have to cherry pick it to the 7.x branch for testing. But then I still miss -SNAPSHOT in the version.

I have tested this locally on the 7.x branch. If you run kibana with yarn start, kibanaVersion does indeed not contain -SNAPSHOT. If you build locally with yarn build, the -SNAPSHOT string is added. This does make manual testing a bit cumbersome indeed -- as the code is rather straightforward, it might make sense merging it soon, and testing it with the snapshot builds we get from https://artifacts-api.elastic.co/.

elasticmachine · 2021-02-10T00:27:35Z

Pinging @elastic/fleet (Team:Fleet)

jen-huang

Approving per @skh's comment (thanks for testing Sonja!).

kibanamachine · 2021-02-10T02:36:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4f44e0b

Metrics [docs]

✅ unchanged

History

💚 Build #104037 succeeded f956da1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with `-SNAPSHOT` not the master branch will use the staging registry. Closes elastic#90131 Co-authored-by: Jen Huang <its.jenetic@gmail.com>

The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with `-SNAPSHOT` not the master branch will use the staging registry. Closes #90131 Co-authored-by: Jen Huang <its.jenetic@gmail.com> Co-authored-by: Nicolas Ruflin <spam@ruflin.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com>

* master: (99 commits) [Fleet] Use Fleet Server indices in the search bar (elastic#90835) [Search Sessions] added an info flyout to session management (elastic#90559) [ILM] Revisit searchable snapshot field after new redesign (elastic#90793) [Alerting] License Errors on Alert List View (elastic#89920) RFC Improve saved object migrations algorithm (elastic#84333) [Lens] (Accessibility) Fix focus on drag and drop actions (elastic#90561) Use new shortcut links to Fleet discuss forums. (elastic#90786) Do not generate an ephemeral encryption key in production. (elastic#81511) [Fleet] Use staging registry for snapshot builds (elastic#90327) Actually deleting x-pack/tsconfig.refs.json (elastic#90898) Add deprecation warning to all Beats CM pages. (elastic#90741) skip flaky suite (elastic#90136) Revert "Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)"" (elastic#90889) remove ref to removed tsconfig file [core.logging] Uses host timezone as default (elastic#90368) [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (elastic#90292) Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)" [dev-utils/ci-stats] support disabling ship errors (elastic#90851) Prefix with / (elastic#90836) [Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244) ...

The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with `-SNAPSHOT` not the master branch will use the staging registry. Closes elastic#90131 Co-authored-by: Jen Huang <its.jenetic@gmail.com> # Conflicts: # x-pack/plugins/fleet/server/services/epm/registry/registry_url.ts

The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with `-SNAPSHOT` not the master branch will use the staging registry. Closes #90131 Co-authored-by: Jen Huang <its.jenetic@gmail.com> # Conflicts: # x-pack/plugins/fleet/server/services/epm/registry/registry_url.ts Co-authored-by: Nicolas Ruflin <spam@ruflin.com>

LeeDr · 2021-02-11T16:01:16Z

I'm pretty sure this missed the 7.11.1 build of Kibana with hash 6882b06 so I changed the label to v7.11.2 but correct me if that's wrong.

skh · 2021-02-11T18:44:21Z

Thanks @LeeDr.

EricDavisX · 2021-02-11T21:52:51Z

The Kibana repo had / has another urgent check-in coming for 7.11.1 so this will be picked up as well.

ruflin · 2021-02-15T10:21:11Z

@skh Thanks for taking this over!

[Fleet] Use staging registry for snapshot builds

f956da1

The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with `-SNAPSHOT` not the master branch will use the staging registry. Closes #90131

ruflin added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 4, 2021

ruflin self-assigned this Feb 4, 2021

Merge remote-tracking branch 'upstream/master' into staging-registry-cdn

4f44e0b

jen-huang marked this pull request as ready for review February 10, 2021 00:27

jen-huang added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Feb 10, 2021

jen-huang approved these changes Feb 10, 2021

View reviewed changes

jen-huang mentioned this pull request Feb 10, 2021

[Fleet] Use staging registry for SNAPSHOT builds #90131

Closed

skh merged commit 634c0b3 into elastic:master Feb 10, 2021

skh mentioned this pull request Feb 10, 2021

[7.x] [Fleet] Use staging registry for snapshot builds (#90327) #90911

Merged

skh added the v7.11.1 label Feb 11, 2021

skh mentioned this pull request Feb 11, 2021

[7.11] [Fleet] Use staging registry for snapshot builds (#90327) #91088

Merged

LeeDr added v7.11.2 and removed v7.11.1 labels Feb 11, 2021

EricDavisX added v7.11.1 and removed v7.11.2 labels Feb 11, 2021

ruflin deleted the staging-registry-cdn branch February 15, 2021 10:21

EricDavisX mentioned this pull request Feb 16, 2021

Update README.md elastic/package-storage#884

Merged

kuisathaverat mentioned this pull request Feb 24, 2021

Cannot run 7.x build candidates with snapshot registry elastic/apm-integration-testing#1068

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Use staging registry for snapshot builds#90327

[Fleet] Use staging registry for snapshot builds#90327
skh merged 2 commits intoelastic:masterfrom
ruflin:staging-registry-cdn

ruflin commented Feb 4, 2021

Uh oh!

ruflin commented Feb 4, 2021

Uh oh!

spalger commented Feb 4, 2021

Uh oh!

skh commented Feb 8, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Feb 10, 2021

Uh oh!

jen-huang left a comment

Uh oh!

kibanamachine commented Feb 10, 2021

Uh oh!

LeeDr commented Feb 11, 2021

Uh oh!

skh commented Feb 11, 2021

Uh oh!

EricDavisX commented Feb 11, 2021

Uh oh!

ruflin commented Feb 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

ruflin commented Feb 4, 2021

Uh oh!

ruflin commented Feb 4, 2021

Uh oh!

spalger commented Feb 4, 2021

Uh oh!

skh commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Feb 10, 2021

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 10, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

LeeDr commented Feb 11, 2021

Uh oh!

skh commented Feb 11, 2021

Uh oh!

EricDavisX commented Feb 11, 2021

Uh oh!

ruflin commented Feb 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

skh commented Feb 8, 2021 •

edited

Loading