[Lens] (Accessibility) Fix focus on drag and drop actions#90561
Merged
mbondyra merged 7 commits intoelastic:masterfrom Feb 10, 2021
Merged
[Lens] (Accessibility) Fix focus on drag and drop actions#90561mbondyra merged 7 commits intoelastic:masterfrom
mbondyra merged 7 commits intoelastic:masterfrom
Conversation
b297588 to
2f43984
Compare
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
d8be514 to
462e10b
Compare
Contributor
Author
|
@elasticmachine merge upstream |
myasonik
approved these changes
Feb 8, 2021
Contributor
myasonik
left a comment
There was a problem hiding this comment.
🚀
Played around with it and couldn't break it. Seems good!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
flash1293
approved these changes
Feb 10, 2021
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and Firefox and works fine for me
| import { useEffect, useState, useCallback } from 'react'; | ||
|
|
||
| const getFirstFocusable = (el: HTMLElement | null) => { | ||
| const focusableSelector = 'button, [href], input, select, textarea, [tabindex]'; |
Contributor
There was a problem hiding this comment.
nit: It's not used in Kibana at the moment, but there's a dependency to tabbable already which is also used by EUI for this task. Maybe we can use it here as well.
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 10, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 10, 2021
* master: (99 commits) [Fleet] Use Fleet Server indices in the search bar (elastic#90835) [Search Sessions] added an info flyout to session management (elastic#90559) [ILM] Revisit searchable snapshot field after new redesign (elastic#90793) [Alerting] License Errors on Alert List View (elastic#89920) RFC Improve saved object migrations algorithm (elastic#84333) [Lens] (Accessibility) Fix focus on drag and drop actions (elastic#90561) Use new shortcut links to Fleet discuss forums. (elastic#90786) Do not generate an ephemeral encryption key in production. (elastic#81511) [Fleet] Use staging registry for snapshot builds (elastic#90327) Actually deleting x-pack/tsconfig.refs.json (elastic#90898) Add deprecation warning to all Beats CM pages. (elastic#90741) skip flaky suite (elastic#90136) Revert "Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)"" (elastic#90889) remove ref to removed tsconfig file [core.logging] Uses host timezone as default (elastic#90368) [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (elastic#90292) Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)" [dev-utils/ci-stats] support disabling ship errors (elastic#90851) Prefix with / (elastic#90836) [Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244) ...
mbondyra
added a commit
that referenced
this pull request
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #90586
When a field from datasource is added to workspace or dimension panel by dnd, the focus stays on the field. I made this decision thinking that user may want to add multiple fields one after another
For all the operations inside dimension panel, the focus moves to the target.
