[Alerting] License Errors on Alert List View by ymao1 · Pull Request #89920 · elastic/kibana

ymao1 · 2021-02-01T20:08:03Z

Resolves #85640

Summary

Made the following updates to the alerts list:

Added a tooltip to the alert status (when the status is error) showing the reason message from the alert execution status.
When the error is a license error, updated the status to say License Error
When the error is a license error, added a button link "Fix" that opens a modals asking if user wants to upgrade their license. Clicking "Manage License" opens the license page
At @mdefazio's suggestion, switched the Name and Status columns on the table

Alert with license error

Error reason tooltip

Manage license modal

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

…ing/licensing-ux

elasticmachine · 2021-02-02T13:57:52Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko

Awesome UX now! Code LGTM.

mdefazio

This looks good! Super tiny nit regarding the button parenthesis (but Gail might disagree).
Also, I think it might be worthwhile tweaking the column widths so there's more room for the alert title. Setting the tableLayout to auto might be enough, but I also remember us going through a PR for this previously.

...ugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.tsx

gchaps

@arisonl Can you please review the licensing text in this PR? There are buttons for "Upgrade license" and "Manage license".

...ugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.tsx

gchaps · 2021-02-03T15:58:19Z

@arisonl Could you please advise on the licensing text in the three screenshots shown in the summary?

…ing/licensing-ux

arisonl · 2021-02-04T19:47:11Z

@gchaps thank you for the heads up, this looks good to me

…ing/licensing-ux

ymao1 · 2021-02-08T12:42:24Z

@elasticmachine merge upstream

ryankeairns · 2021-02-08T21:40:49Z

In chatting with @gchaps , we felt the modal copy could use some clarification as there is somewhat of a mismatch currently (i.e. contact adminstrator / Manage license).

Since we can't very easily determine what role a person has - or what they have the ability to do - perhaps the text ought to be more general and we leave the available options up to the License Management page.

The modal title and text would be:

Gold license required

Alert example.people-in-space is disabled because it requires a Gold license. Continue to the License Management page to view upgrade options.

[ Cancel ] [ Manage license ]

…ing/licensing-ux

gchaps · 2021-02-09T16:15:08Z

A few minor tweaks.

Tooltip:

Alert example.people-in-space is disabled because it requires a Gold license. Go to License Management to view upgrade options.

Modal:

Gold license required

Alert example.people-in-space is disabled because it requires a Gold license. Continue to License Management to view upgrade options.

[ Cancel ] [ Manage license ]

ymao1 · 2021-02-09T16:19:12Z

A few minor tweaks.

Tooltip:

Alert example.people-in-space is disabled because it requires a Gold license. Go to License Management to view upgrade options.

@gchaps Because I have the tooltip showing on any alert execution error and not just license errors, I'm just showing the error from the execution status with no modifications. The current wording is also what shows up in the logs. Would it make sense to update the log message to say "Go to License Management to view upgrade options" as well?

… into alerting/licensing-ux

ymao1 · 2021-02-09T17:01:03Z

@gchaps @ryankeairns Updated modal:

ymao1 · 2021-02-09T18:07:24Z

@elasticmachine merge upstream

pmuellr

LGTM, seems to work as advertised. Made a few comments/notes/questions, no blockers.

.../triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.test.tsx

...ugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.tsx

…ing/licensing-ux

… into alerting/licensing-ux

ymao1 · 2021-02-10T00:26:30Z

@elasticmachine merge upstream

…ing/licensing-ux

kibanamachine · 2021-02-10T04:42:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 44fedc4

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	337	338	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.4MB	1.4MB	+2.4KB

History

💔 Build #105455 failed ab2bb14
💔 Build #105446 failed a1df060
💔 Build #105439 failed 48db829
💚 Build #105295 succeeded 50910cd
💔 Build #105253 failed 4a134a7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Adding tooltips to alert list and modal for license upgrade * Fixing typings * Custom License Error status. Moving modal to alerts list page * Adding unit test * Cleanup * Unit tests * Removing tooltip from alert name * License * PR fixes * Updating modal wording * Updating license state error message * i18n fix * Fixing functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (99 commits) [Fleet] Use Fleet Server indices in the search bar (elastic#90835) [Search Sessions] added an info flyout to session management (elastic#90559) [ILM] Revisit searchable snapshot field after new redesign (elastic#90793) [Alerting] License Errors on Alert List View (elastic#89920) RFC Improve saved object migrations algorithm (elastic#84333) [Lens] (Accessibility) Fix focus on drag and drop actions (elastic#90561) Use new shortcut links to Fleet discuss forums. (elastic#90786) Do not generate an ephemeral encryption key in production. (elastic#81511) [Fleet] Use staging registry for snapshot builds (elastic#90327) Actually deleting x-pack/tsconfig.refs.json (elastic#90898) Add deprecation warning to all Beats CM pages. (elastic#90741) skip flaky suite (elastic#90136) Revert "Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)"" (elastic#90889) remove ref to removed tsconfig file [core.logging] Uses host timezone as default (elastic#90368) [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (elastic#90292) Revert "[Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244)" [dev-utils/ci-stats] support disabling ship errors (elastic#90851) Prefix with / (elastic#90836) [Metrics UI] Add Metrics Anomaly Alert Type (elastic#89244) ...

* Adding tooltips to alert list and modal for license upgrade * Fixing typings * Custom License Error status. Moving modal to alerts list page * Adding unit test * Cleanup * Unit tests * Removing tooltip from alert name * License * PR fixes * Updating modal wording * Updating license state error message * i18n fix * Fixing functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

ymao1 added 5 commits January 29, 2021 10:29

Adding tooltips to alert list and modal for license upgrade

f82f5b3

Merge branch 'master' of https://github.com/elastic/kibana into alert…

c3e350b

…ing/licensing-ux

Fixing typings

c817594

Merge branch 'master' of https://github.com/elastic/kibana into alert…

4546870

…ing/licensing-ux

Custom License Error status. Moving modal to alerts list page

9e3055c

ymao1 self-assigned this Feb 1, 2021

ymao1 added 6 commits February 1, 2021 21:25

Adding unit test

09af8f1

Cleanup

bcde1da

Merge branch 'master' of https://github.com/elastic/kibana into alert…

0c2ad1b

…ing/licensing-ux

Unit tests

5188f14

Merge branch 'master' of https://github.com/elastic/kibana into alert…

bd42c6f

…ing/licensing-ux

Removing tooltip from alert name

e5acc75

ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.12.0 v8.0.0 labels Feb 2, 2021

ymao1 marked this pull request as ready for review February 2, 2021 13:57

ymao1 requested a review from a team as a code owner February 2, 2021 13:57

ymao1 requested review from gchaps and mdefazio February 2, 2021 13:58

YulNaumenko approved these changes Feb 2, 2021

View reviewed changes

mdefazio requested changes Feb 3, 2021

View reviewed changes

...ugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.tsx Outdated Show resolved Hide resolved

gchaps reviewed Feb 3, 2021

View reviewed changes

...ugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.tsx Outdated Show resolved Hide resolved

ymao1 added 2 commits February 4, 2021 07:52

Merge branch 'master' of https://github.com/elastic/kibana into alert…

e985bd8

…ing/licensing-ux

License

aa05bb5

Merge branch 'master' of https://github.com/elastic/kibana into alert…

a31895c

…ing/licensing-ux

Merge branch 'master' into alerting/licensing-ux

391ad6e

ryankeairns mentioned this pull request Feb 8, 2021

[Alerts][License] Ability to phrase the licensing error message text with the CTA support. #85887

Open

Merge branch 'master' of https://github.com/elastic/kibana into alert…

e84d0ae

…ing/licensing-ux

ymao1 added 2 commits February 9, 2021 11:55

Merge branch 'alerting/licensing-ux' of https://github.com/ymao1/kibana…

6f85e7d

… into alerting/licensing-ux

Updating modal wording

4a134a7

Merge branch 'master' into alerting/licensing-ux

50910cd

pmuellr approved these changes Feb 9, 2021

View reviewed changes

ymao1 added 3 commits February 9, 2021 18:43

Merge branch 'master' of https://github.com/elastic/kibana into alert…

dadd4f2

…ing/licensing-ux

Updating license state error message

9a1fccc

Merge branch 'alerting/licensing-ux' of https://github.com/ymao1/kibana…

48db829

… into alerting/licensing-ux

kibanamachine and others added 5 commits February 9, 2021 19:26

Merge branch 'master' into alerting/licensing-ux

a1df060

Merge branch 'master' of https://github.com/elastic/kibana into alert…

f836c28

…ing/licensing-ux

i18n fix

ab2bb14

Fixing functional test

5c8aa76

Merge branch 'master' of https://github.com/elastic/kibana into alert…

44fedc4

…ing/licensing-ux

ymao1 merged commit 3e91bc7 into elastic:master Feb 10, 2021

ymao1 mentioned this pull request Feb 10, 2021

[7.x] [Alerting] License Errors on Alert List View (#89920) #90932

Merged

ymao1 deleted the alerting/licensing-ux branch March 25, 2021 14:42

ymao1 mentioned this pull request May 13, 2021

[Alerting UI] Rules list does not give reason why rule is disabled when it is due to license #100065

Closed

Conversation

ymao1 commented Feb 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Feb 2, 2021

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

mdefazio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gchaps commented Feb 3, 2021

Uh oh!

arisonl commented Feb 4, 2021

Uh oh!

ymao1 commented Feb 8, 2021

Uh oh!

ryankeairns commented Feb 8, 2021

Gold license required

Uh oh!

gchaps commented Feb 9, 2021

Gold license required

Uh oh!

ymao1 commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ymao1 commented Feb 9, 2021

Uh oh!

ymao1 commented Feb 9, 2021

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ymao1 commented Feb 10, 2021

Uh oh!

kibanamachine commented Feb 10, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ymao1 commented Feb 1, 2021 •

edited

Loading

ymao1 commented Feb 9, 2021 •

edited

Loading