[Maps] rename file_upload to maps_file_upload#89225
Merged
nreese merged 6 commits intoelastic:masterfrom Jan 26, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
History
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Jan 26, 2021
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 26, 2021
* migrate file_upload plugin to maps_file_upload * update plugins list * results of running node scripts/build_plugin_list_docs * fix build problems * remove fileUpload from limits.yml Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jan 27, 2021
* migrate file_upload plugin to maps_file_upload * update plugins list * results of running node scripts/build_plugin_list_docs * fix build problems * remove fileUpload from limits.yml Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server code in file_upload was copied from ml plugin 24 months ago. The original plan was to then migrate ML to use the file_upload plugin and remove the duplicated code in the ml plugin. This did not happen and now the code paths have diverged to much to reconcile.
This PR renames file_upload to maps_file_upload to vacate the file_upload namespace so that we can restart the process of moving ml file upload code into a reusable plugin.