Skip to content

[7.x] [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (#90292)#90946

Merged
nreese merged 5 commits intoelastic:7.xfrom
nreese:backport/7.x/pr-90292
Feb 10, 2021
Merged

[7.x] [Maps] remove maps_file_upload plugin and fold public folder into file_upload plugin (#90292)#90946
nreese merged 5 commits intoelastic:7.xfrom
nreese:backport/7.x/pr-90292

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Feb 10, 2021

Backports the following commits to 7.x:

…e_upload plugin (elastic#90292)

* get geojson working with api/file_upload/import

* remove maps_file_upload server code

* remove common folder

* remove maps_file_upload plugin

* fix tsconfig paths

* rename file_upload plugin in maps tsconfig

* fix file path

* node scripts/build_plugin_list_docs

* fix webpack compile errors

* telemetry schema cleanup, i18n cleanup, limits cleanup

* remove mapsFileUpload from limits.yml

* remove index pattern link test case

* update telemetry/v2/clusters/_stats for new file_upload path

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Feb 10, 2021

@elasticmachine merge upstream

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Feb 10, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fileUpload - 189 +189
mapsFileUpload 187 - -187
ml 1735 1732 -3
total -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileUpload - 825.2KB ⚠️ +825.2KB
mapsFileUpload 825.8KB - -825.8KB
ml 6.3MB 6.3MB -2.0KB
total -2.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fileUpload - 10.4KB +10.4KB
maps 139.0KB 139.0KB -4.0B
mapsFileUpload 7.2KB - -7.2KB
ml 59.1KB 59.3KB +237.0B
total +3.5KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
file-upload-telemetry 2 - -2
Unknown metric groups

async chunk count

id before after diff
fileUpload - 1 +1
mapsFileUpload 1 - -1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 51a14de into elastic:7.x Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants