[Workplace Search] Fix Source Settings bug #90242
Merged
scottybollinger merged 5 commits intoelastic:masterfrom Feb 4, 2021
Merged
[Workplace Search] Fix Source Settings bug #90242scottybollinger merged 5 commits intoelastic:masterfrom
scottybollinger merged 5 commits intoelastic:masterfrom
Conversation
Verified that this works as expected
Contributor
Author
|
@elasticmachine merge upstream |
yakhinvadim
approved these changes
Feb 4, 2021
Contributor
yakhinvadim
left a comment
There was a problem hiding this comment.
Sorry, I missed this PR at first! LGTM 👍
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Feb 4, 2021
* Remove comment Verified that this works as expected * Replaces usage from SourceLogic to AddSourceLogic * Remove unused duplicate code Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2021
* master: (244 commits) [maps] Top hits per entity--change to title to use recent, minor edits (elastic#89254) [DOCS] Update installation details (elastic#90354) RFC for automatically generated typescript API documentation for every plugins public services, types, and functionality (elastic#86704) Elastic Maps Server config is `host` not `hostname` (elastic#90234) Use doc link services in index pattern management (elastic#89937) [Fleet] Managed Agent Policy (elastic#88688) [Workplace Search] Fix Source Settings bug (elastic#90242) [Enterprise Search] Refactor MockRouter test helper to not store payload (elastic#90206) Use doc link service in more Stack Monitoring pages (elastic#89050) [App Search] Relevance Tuning logic - actions and selectors only, no listeners (elastic#89313) Remove UI filters from UI (elastic#89793) Use newfeed.service config for all newsfeeds (elastic#90252) skip flaky suite (elastic#85086) Add readme to geo containment alert covering test alert setup (elastic#89625) [APM] Enabling yesterday option when 24 hours is selected (elastic#90017) Test user for maps tests under import geoJSON tests (elastic#86015) [Lens] Hide column in table (elastic#88680) [Security Solution][Detections] Reduce detection engine reliance on _source (elastic#89371) [Discover] Minor cleanup (elastic#90260) [Search Session][Management] Rename "cancel" button and delete "Reload" button (elastic#90015) ...
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
scottybollinger
added a commit
that referenced
this pull request
Feb 9, 2021
* Remove comment Verified that this works as expected * Replaces usage from SourceLogic to AddSourceLogic * Remove unused duplicate code Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Back in this PR, I made the decision to duplicate the
getSourceConfigDatafunctionality to completely separate the functionality from settings (updating) and adding a source. From that PR:Because of oauth issues I was not able to adequately test it and now realize it does not work because the shared
SaveConfigpulls the data it needs from the logic file. I went ahead and removed the duplicate code and let theAddSourceLogicmodule be the single source of truth for both adding and updating a connector. In the future, we should renameAddSourceLogicto something more generic, but I wanted to try and get this in before 7.12 so we can address that later.Also, my comment in that PR about " the loading states in each tree" is unwarranted because the only async call is for the
AddSourceLogicendpoint.Checklist