Skip to content

[7.x] [Workplace Search] Fix Source Settings bug (#90242)#90325

Merged
scottybollinger merged 2 commits intoelastic:7.xfrom
scottybollinger:backport/7.x/pr-90242
Feb 9, 2021
Merged

[7.x] [Workplace Search] Fix Source Settings bug (#90242)#90325
scottybollinger merged 2 commits intoelastic:7.xfrom
scottybollinger:backport/7.x/pr-90242

Conversation

@scottybollinger
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Remove comment

Verified that this works as expected

* Replaces usage from SourceLogic to AddSourceLogic

* Remove unused duplicate code

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@scottybollinger scottybollinger added the backport This PR is a backport of another PR label Feb 4, 2021
@scottybollinger
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@scottybollinger scottybollinger enabled auto-merge (squash) February 9, 2021 16:02
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.8MB 1.8MB -486.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit d1a1287 into elastic:7.x Feb 9, 2021
@scottybollinger scottybollinger deleted the backport/7.x/pr-90242 branch February 9, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants