Skip to content

Use doc link services in index pattern management#89937

Merged
lcawl merged 2 commits intoelastic:masterfrom
lcawl:doc-links-index-patterns
Feb 4, 2021
Merged

Use doc link services in index pattern management#89937
lcawl merged 2 commits intoelastic:masterfrom
lcawl:doc-links-index-patterns

Conversation

@lcawl
Copy link
Copy Markdown
Member

@lcawl lcawl commented Feb 1, 2021

Summary

Related to #88107

This PR replaces a hard-coded link in src/plugins/index_pattern_management/public/components/edit_index_pattern/edit_index_pattern.tsx with a keyword from the doc link service.

Screenshot

image

@lcawl lcawl force-pushed the doc-links-index-patterns branch from b6898d0 to d106110 Compare February 1, 2021 23:06
@lcawl lcawl added Feature:Data Views Data Views code and UI - index patterns before 8.0 v7.12.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Docs labels Feb 2, 2021
@lcawl lcawl marked this pull request as ready for review February 2, 2021 01:15
@lcawl lcawl requested a review from a team as a code owner February 2, 2021 01:15
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl requested a review from a team February 2, 2021 15:29
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@lcawl
Copy link
Copy Markdown
Member Author

lcawl commented Feb 4, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternManagement 555.9KB 556.0KB +41.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 465.6KB 465.7KB +44.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 808bd44 into elastic:master Feb 4, 2021
@lcawl lcawl deleted the doc-links-index-patterns branch February 4, 2021 20:49
lcawl added a commit to lcawl/kibana that referenced this pull request Feb 4, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 4, 2021
* master: (244 commits)
  [maps] Top hits per entity--change to title to use recent, minor edits (elastic#89254)
  [DOCS] Update installation details (elastic#90354)
  RFC for automatically generated typescript API documentation for every plugins public services, types, and functionality (elastic#86704)
  Elastic Maps Server config is `host` not `hostname` (elastic#90234)
  Use doc link services in index pattern management (elastic#89937)
  [Fleet] Managed Agent Policy (elastic#88688)
  [Workplace Search] Fix Source Settings bug  (elastic#90242)
  [Enterprise Search] Refactor MockRouter test helper to not store payload (elastic#90206)
  Use doc link service in more Stack Monitoring pages (elastic#89050)
  [App Search] Relevance Tuning logic - actions and selectors only, no listeners (elastic#89313)
  Remove UI filters from UI (elastic#89793)
  Use newfeed.service config for all newsfeeds (elastic#90252)
  skip flaky suite (elastic#85086)
  Add readme to geo containment alert covering test alert setup (elastic#89625)
  [APM] Enabling yesterday option when 24 hours is selected (elastic#90017)
  Test user for maps tests under import geoJSON tests (elastic#86015)
  [Lens] Hide column in table (elastic#88680)
  [Security Solution][Detections] Reduce detection engine reliance on _source (elastic#89371)
  [Discover] Minor cleanup (elastic#90260)
  [Search Session][Management] Rename "cancel" button and delete "Reload" button (elastic#90015)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants