Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
reviewed
Feb 2, 2021
Comment on lines
+33
to
+40
| const newLocation = { | ||
| ...history.location, | ||
| search: fromQuery({ | ||
| ...toQuery(history.location.search), | ||
| transactionType: selectedTransactionType, | ||
| }), | ||
| }; | ||
| history.push(newLocation); |
Contributor
There was a problem hiding this comment.
We have a helper for making this a little easier:
Suggested change
| const newLocation = { | |
| ...history.location, | |
| search: fromQuery({ | |
| ...toQuery(history.location.search), | |
| transactionType: selectedTransactionType, | |
| }), | |
| }; | |
| history.push(newLocation); | |
| urlHelpers.push(history, { transactionType: selectedTransactionType }); |
Contributor
Author
There was a problem hiding this comment.
Cool. I copied this from the ui filters so this is much nicer.
sorenlouv
approved these changes
Feb 2, 2021
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
lgtm! Should we attempt to remove the projections in a follow-up PR?
Contributor
Author
Yes. I updated some of the items on #84526 so that should get done. |
justinkambic
approved these changes
Feb 4, 2021
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Code changes seem fine, smoke test was fine. LGTM
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Feb 4, 2021
* Start moving some stuff * Move some stuff around * more * Transactions label * some snake casing * i18n fix * Remove unused ui filters endpoints * Updates to select * remove projections * Use urlHelpers.push * License change
smith
added a commit
that referenced
this pull request
Feb 4, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2021
* master: (244 commits) [maps] Top hits per entity--change to title to use recent, minor edits (elastic#89254) [DOCS] Update installation details (elastic#90354) RFC for automatically generated typescript API documentation for every plugins public services, types, and functionality (elastic#86704) Elastic Maps Server config is `host` not `hostname` (elastic#90234) Use doc link services in index pattern management (elastic#89937) [Fleet] Managed Agent Policy (elastic#88688) [Workplace Search] Fix Source Settings bug (elastic#90242) [Enterprise Search] Refactor MockRouter test helper to not store payload (elastic#90206) Use doc link service in more Stack Monitoring pages (elastic#89050) [App Search] Relevance Tuning logic - actions and selectors only, no listeners (elastic#89313) Remove UI filters from UI (elastic#89793) Use newfeed.service config for all newsfeeds (elastic#90252) skip flaky suite (elastic#85086) Add readme to geo containment alert covering test alert setup (elastic#89625) [APM] Enabling yesterday option when 24 hours is selected (elastic#90017) Test user for maps tests under import geoJSON tests (elastic#86015) [Lens] Hide column in table (elastic#88680) [Security Solution][Detections] Reduce detection engine reliance on _source (elastic#89371) [Discover] Minor cleanup (elastic#90260) [Search Session][Management] Rename "cancel" button and delete "Reload" button (elastic#90015) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EuiPageScreenshot of new transaction type select and placement of correlations button:
References #84526.