[Search Session][Management] Rename "cancel" button and delete "Reload" button#90015
Merged
lizozom merged 13 commits intoelastic:masterfrom Feb 4, 2021
Merged
[Search Session][Management] Rename "cancel" button and delete "Reload" button#90015lizozom merged 13 commits intoelastic:masterfrom
lizozom merged 13 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
This was referenced Feb 2, 2021
added 2 commits
February 2, 2021 18:48
Dosant
approved these changes
Feb 3, 2021
Contributor
Dosant
left a comment
There was a problem hiding this comment.
Tested, LGTM except I think this toast also needs text change?
btw, not sure I like and follow this wording here will expire any cached results.
I assume this is an official async search terminology?
If not then Deleting the search session deletes its cached search results sounds more natural to me
added 10 commits
February 3, 2021 17:43
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Feb 4, 2021
…d" button (elastic#90015) * Rename management button to "delete" * fix jest * Delete reload action from management * Added both cancel and delete session * Improve texts * fix test * ts * doc * fix jest
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2021
* master: (244 commits) [maps] Top hits per entity--change to title to use recent, minor edits (elastic#89254) [DOCS] Update installation details (elastic#90354) RFC for automatically generated typescript API documentation for every plugins public services, types, and functionality (elastic#86704) Elastic Maps Server config is `host` not `hostname` (elastic#90234) Use doc link services in index pattern management (elastic#89937) [Fleet] Managed Agent Policy (elastic#88688) [Workplace Search] Fix Source Settings bug (elastic#90242) [Enterprise Search] Refactor MockRouter test helper to not store payload (elastic#90206) Use doc link service in more Stack Monitoring pages (elastic#89050) [App Search] Relevance Tuning logic - actions and selectors only, no listeners (elastic#89313) Remove UI filters from UI (elastic#89793) Use newfeed.service config for all newsfeeds (elastic#90252) skip flaky suite (elastic#85086) Add readme to geo containment alert covering test alert setup (elastic#89625) [APM] Enabling yesterday option when 24 hours is selected (elastic#90017) Test user for maps tests under import geoJSON tests (elastic#86015) [Lens] Hide column in table (elastic#88680) [Security Solution][Detections] Reduce detection engine reliance on _source (elastic#89371) [Discover] Minor cleanup (elastic#90260) [Search Session][Management] Rename "cancel" button and delete "Reload" button (elastic#90015) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete any items that are not applicable to this PR.
For maintainers