[Workplace Search] Split out logic between Source and AddSource#85658
Merged
scottybollinger merged 8 commits intoelastic:masterfrom Dec 15, 2020
Merged
Conversation
This commit merely copies SourceLogic and renames it to AddSourceLogic with the name of the component and interfaces changed. This will make reviewing the changes easier later
Contributor
Author
|
@elasticmachine merge upstream |
yakhinvadim
approved these changes
Dec 15, 2020
Contributor
yakhinvadim
left a comment
There was a problem hiding this comment.
It's much better now! Thank you for such an easy to review history.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we have a 650-line SourceLogic file that has all the logic for viewing a source and also adding a source. This PR splits out the logic for adding a source into its own file. This will allow for easier testing and better maintainability.
NOTE: Both
AddSourceandSourceSettingsuse agetSourceConfigDatamethod to fetch config data. I toyed with using one of these to provide for the other and decided to just duplicate the method because of all the loading states in each tree that rely on this method.