[Visualize] Vis listing page breaks on unknown vis type#82018
Merged
stratoula merged 3 commits intoelastic:masterfrom Nov 2, 2020
Merged
[Visualize] Vis listing page breaks on unknown vis type#82018stratoula merged 3 commits intoelastic:masterfrom
stratoula merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
approved these changes
Oct 30, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested with Lens vis and broken vis type with and without experimental visualization types - works as expected.
Contributor
|
@stratoula Could you backport this into 7.10.1 as well once it exists? |
Contributor
Author
|
Sure @flash1293! |
lizozom
reviewed
Oct 30, 2020
| ) : ( | ||
| field | ||
| ), | ||
| }, |
Contributor
There was a problem hiding this comment.
I would render a string stating "Unknown Type" into the type column, to clarify what happened, together with a "warning" icon.
Might even consider adding a tooltip with more details.
Other than that looks good.
Contributor
|
@stratoula IMO the tooltip should say something like |
Contributor
Author
|
@lizozom the setting doesn't solve the problem. The type is not correct so it can't be used either with it enabled or disabled. |
Contributor
Author
|
@lizozom I updated it, below is a ss with the change 🙂 |
lizozom
approved these changes
Oct 30, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Nov 2, 2020
* [Visualize] Vis listing page breaks on unknown vis type * Display a warning badge in case of an error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 2, 2020
* master: Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) Rename "service overview" to "service inventory" (elastic#81933) adjust policy test to drop test for server addresses (elastic#82120) Cleanup/codeowners (elastic#82146) [DOCS] Updates add data content (elastic#81093) [DOCS] Remove index mgmt docs (elastic#82099) [Search] fix cancelation related memory leaks (elastic#81996)
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 2, 2020
…e-details-overlay * 'master' of github.com:elastic/kibana: (72 commits) [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487) [APM] Scale transaction rate correctly (elastic#82155) Upgrade to hapi version 18 (elastic#80468) [Uptime] Remove custom handling of license enabling (elastic#82019) [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579) Enable send to background in Vega (elastic#82229) Enable send to background in Timelion (elastic#82232) [Actions & Connectors] removes Connector flyouts after usage (elastic#82126) Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) ...
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Nov 16, 2020
* [Visualize] Vis listing page breaks on unknown vis type * Display a warning badge in case of an error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81881.
This PR closes two bugs:
visualize:enableLabsis disabled on advanced settings and the listing page has at least one Lens vis it doesn't load with the following error:I changed it in order to make the type optional. When there is an error on the vis item, the saved object has also a string field (string) so I depend on this to disable the link both in the title of the vis and on the edit icon.