[Actions & Connectors] removes Connector flyouts after usage#82126
Merged
gmmorris merged 6 commits intoelastic:masterfrom Nov 2, 2020
Merged
[Actions & Connectors] removes Connector flyouts after usage#82126gmmorris merged 6 commits intoelastic:masterfrom
gmmorris merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
shahzad31
approved these changes
Oct 30, 2020
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
YulNaumenko
approved these changes
Oct 30, 2020
Contributor
YulNaumenko
left a comment
There was a problem hiding this comment.
LGTM! Tested locally and it works as expected
cnasikas
reviewed
Oct 30, 2020
x-pack/plugins/security_solution/public/cases/components/configure_cases/index.tsx
Show resolved
Hide resolved
cnasikas
reviewed
Oct 30, 2020
x-pack/plugins/security_solution/public/cases/components/configure_cases/index.tsx
Show resolved
Hide resolved
cnasikas
approved these changes
Oct 30, 2020
Member
cnasikas
left a comment
There was a problem hiding this comment.
Code LGTM regarding Security Solution! Tested locally and everything work as expected.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 2, 2020
…#82126) We've had several bugs over the past few months due to flyouts retaining state between renders. This ensure we remove these flyouts entirely in between usage to avoid such issues recurring.
This was referenced Nov 2, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 2, 2020
…e-details-overlay * 'master' of github.com:elastic/kibana: (72 commits) [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487) [APM] Scale transaction rate correctly (elastic#82155) Upgrade to hapi version 18 (elastic#80468) [Uptime] Remove custom handling of license enabling (elastic#82019) [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579) Enable send to background in Vega (elastic#82229) Enable send to background in Timelion (elastic#82232) [Actions & Connectors] removes Connector flyouts after usage (elastic#82126) Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) ...
gmmorris
added a commit
that referenced
this pull request
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81757
We've had several bugs over the past few months due to flyouts retaining state between renders.
This ensure we remove these flyouts entirely in between usage to avoid such issues recurring.
Checklist
Delete any items that are not applicable to this PR.
For maintainers