[Telemetry] Remove from and to timestamps from usage stats APIs#81579
Merged
Bamieh merged 12 commits intoelastic:masterfrom Nov 2, 2020
Merged
[Telemetry] Remove from and to timestamps from usage stats APIs#81579Bamieh merged 12 commits intoelastic:masterfrom
from and to timestamps from usage stats APIs#81579Bamieh merged 12 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
… telemetry/optional_to
chrisronline
approved these changes
Oct 27, 2020
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
LGTM for stack monitoring. It seems you only touched your files in the monitoring plugin
x-pack/plugins/monitoring/server/telemetry_collection/get_cluster_uuids.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/telemetry_collection/get_all_stats.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/telemetry_collection/get_high_level_stats.test.ts
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/telemetry_collection/get_kibana_stats.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
previously requested changes
Oct 28, 2020
Contributor
There was a problem hiding this comment.
Thanks for tackling this!
It works as it is right now but we should be using the monitoring/common/constants.ts file for all the hard-coded time intervals, like we do for the TELEMETRY_COLLECTION_INTERVAL. That way we can keep them in one place and document each value.
afharo
approved these changes
Nov 2, 2020
Member
afharo
left a comment
There was a problem hiding this comment.
LGTM! Thank you for doing this 🧡
Contributor
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
All requested changes addressed. Approved by @afharo
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Nov 2, 2020
…lastic#81579) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/functional/apps/infra/home_page.ts # x-pack/test/functional/apps/infra/logs_source_configuration.ts
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 2, 2020
…e-details-overlay * 'master' of github.com:elastic/kibana: (72 commits) [CCR] Update README.md on how to start 2 clusters for testing (elastic#81487) [APM] Scale transaction rate correctly (elastic#82155) Upgrade to hapi version 18 (elastic#80468) [Uptime] Remove custom handling of license enabling (elastic#82019) [Telemetry] Remove `from` and `to` timestamps from usage stats APIs (elastic#81579) Enable send to background in Vega (elastic#82229) Enable send to background in Timelion (elastic#82232) [Actions & Connectors] removes Connector flyouts after usage (elastic#82126) Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage api now accepts a
timestampstring or unix timestamp number. The api no longer accepts aTimeRangeparameter.Restrict
fromandtousage to only inside monitoring collection where it is used.Increase fetching Cluster_uuid query timestamp difference from 20 minutes to 3 hours. Currently if a cluster has not reported anything in the last 20 minutes then we do not send any data related to that cluster. Increasing the query from 20 min to 3 hours provides better guarantees on capturing all the connected monitoring clusters.
This change makes it easier to work on alejandro's RFC to completely decouple monitoring from telemetry.
Closes #57782