Merged
Conversation
added 2 commits
October 30, 2020 15:28
flash1293
reviewed
Oct 30, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Found a small typo. Also I guess we should add the index pattern management plugin to the app arch list outside of the coverage mapping
src/plugins/management/README.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| # Managament Plugin | |||
Contributor
Author
|
@flash1293 Thanks for catching the typo. The index pattern management section didn't had any codeowner outside CC yet, I wanted to leave that decicions to App Arch if they want to set it up to their list. |
flash1293
approved these changes
Oct 30, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
LGTM in that case, I will let the app arch team know
Contributor
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 2, 2020
* master: Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) Rename "service overview" to "service inventory" (elastic#81933) adjust policy test to drop test for server addresses (elastic#82120) Cleanup/codeowners (elastic#82146) [DOCS] Updates add data content (elastic#81093) [DOCS] Remove index mgmt docs (elastic#82099) [Search] fix cancelation related memory leaks (elastic#81996)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This file adds our missing READMEs. It also removed redundant CC lines from CODEOWNERS (since we already have them under our regular CODEOWNERSHIP the additional CC line is not needed), also it moves the index pattern management plugin completely to App Arch (as we decided recently).