Rename "service overview" to "service inventory"#81933
Merged
smith merged 4 commits intoelastic:masterfrom Oct 30, 2020
Merged
Conversation
To remove confusion when implementing elastic#81718, rename the existing "service overview" to "service inventory." * Rename `ServiceOverviewLink` to `ServiceInventoryLink` * Remove service inventory test snapshots * Rename `ServiceOverview` to `ServiceInventory` * Add `service_inventory` to pageview tracking * Rename i18n keys for service inventory * Change "return to overview" link to "return to inventory" on settings page * Rename `fetchOverviewPageData` to `fetchObservabilityOverviewPageData`
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
ogupte
reviewed
Oct 28, 2020
| useTrackPageview({ app: 'apm', path: 'services_overview' }); | ||
| useTrackPageview({ app: 'apm', path: 'service_inventory' }); | ||
| useTrackPageview({ app: 'apm', path: 'services_overview', delay: 15000 }); | ||
| useTrackPageview({ app: 'apm', path: 'service_inventory', delay: 15000 }); |
Contributor
There was a problem hiding this comment.
Should this replace the old one? Or is this so that existing queries won't break? Maybe we can add a TODO here to make sure to remove the old ones for next major release.
Contributor
Author
There was a problem hiding this comment.
We can remove the old one once nobody at Elastic is using it. I left them both with the intention that we could remove the old one once everything uses it ages out and doesn't need the data.
I'm not even sure if anybody is using it or how I could find out but I'll ask.
Contributor
Author
There was a problem hiding this comment.
It's being used.
@sqren said:
Since it’s the landing page in APM it’s the page most suitable for tracking active ui usage. I therefore think we should consider keeping the old name - perhaps add a comment in the code that it’s kept unchanged for backwards compatibility reason
Going to remove the new entries, keep the old ones, and leave a comment.
ogupte
approved these changes
Oct 28, 2020
Contributor
Author
|
@elasticmachine merge upstream |
shahzad31
approved these changes
Oct 30, 2020
Contributor
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Oct 30, 2020
To remove confusion when implementing elastic#81718, rename the existing "service overview" to "service inventory." * Rename `ServiceOverviewLink` to `ServiceInventoryLink` * Remove service inventory test snapshots * Rename `ServiceOverview` to `ServiceInventory` * Add `service_inventory` to pageview tracking * Rename i18n keys for service inventory * Change "return to overview" link to "return to inventory" on settings page * Rename `fetchOverviewPageData` to `fetchObservabilityOverviewPageData`
smith
added a commit
that referenced
this pull request
Oct 30, 2020
To remove confusion when implementing #81718, rename the existing "service overview" to "service inventory." * Rename `ServiceOverviewLink` to `ServiceInventoryLink` * Remove service inventory test snapshots * Rename `ServiceOverview` to `ServiceInventory` * Add `service_inventory` to pageview tracking * Rename i18n keys for service inventory * Change "return to overview" link to "return to inventory" on settings page * Rename `fetchOverviewPageData` to `fetchObservabilityOverviewPageData`
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 2, 2020
* master: Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) Rename "service overview" to "service inventory" (elastic#81933) adjust policy test to drop test for server addresses (elastic#82120) Cleanup/codeowners (elastic#82146) [DOCS] Updates add data content (elastic#81093) [DOCS] Remove index mgmt docs (elastic#82099) [Search] fix cancelation related memory leaks (elastic#81996)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove confusion when implementing #81718, rename the existing "service overview" to "service inventory."
ServiceOverviewLinktoServiceInventoryLinkServiceOverviewtoServiceInventoryservice_inventoryto pageview trackingfetchOverviewPageDatatofetchObservabilityOverviewPageData