[SECURITY_SOLUTION] adjust policy test to drop test for server addresses#82120
Merged
kevinlog merged 2 commits intoelastic:masterfrom Oct 30, 2020
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
pzl
approved these changes
Oct 30, 2020
Member
pzl
left a comment
There was a problem hiding this comment.
looks like the only part of the now-excluded info I would consider still testworthy was agentFullPolicy.id, but that seems to be mirrored in agentFullPolicy.inputs.id already. So 👍
This was referenced Oct 30, 2020
kevinlog
added a commit
to kevinlog/kibana
that referenced
this pull request
Oct 30, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kevinlog
added a commit
that referenced
this pull request
Oct 30, 2020
kevinlog
added a commit
that referenced
this pull request
Oct 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 2, 2020
* master: Add derivative function (elastic#81178) [Discover] Deangularize context_app.html, part 3 (elastic#81838) [Visualize] Vis listing page breaks on unknown vis type (elastic#82018) Rename `batchSize` parameter to `batch_size` to be consisten with the API namings guidelines. (elastic#82123) Minor edits in Single Metric Viewer (elastic#82159) [Actions] Fix type contract (elastic#82168) Upgrade EUI to v30.1.1 (elastic#81499) Skip failing ES snapshot test (elastic#82207) Skip ES snapshot failing suite (elastic#82206) [Alerting UI] Grouped list of alert types using producers in Types filter of Alerts tab (elastic#81876) [Maps] convert vector style component to typescript round 1 (elastic#81961) Fix link to upgrade assistant (elastic#82138) Rename "service overview" to "service inventory" (elastic#81933) adjust policy test to drop test for server addresses (elastic#82120) Cleanup/codeowners (elastic#82146) [DOCS] Updates add data content (elastic#81093) [DOCS] Remove index mgmt docs (elastic#82099) [Search] fix cancelation related memory leaks (elastic#81996)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust this policy details test to drop the check for the server URLs since CI and Cloud tests configure them differently. The scope of our test is to ensure that changes to the Endpoint config propagate and that is still accomplished here without the expanded surface area that would make this test less portable and more brittle.
As an example, look at this test output to see how configs differ.
https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-kibana-tests/921/JOB=xpackExtGrp2,TASK=saas_run_kibana_tests,node=linux-immutable/testReport/X-Pack%20Endpoint%20Functional%20Tests1/x-pack_test_security_solution_endpoint_apps_endpoint_policy_details%C2%B7ts/endpoint_When_on_the_Endpoint_Policy_Details_Page_and_the_save_button_is_clicked_should_have_updated_policy_data_in_overall_Agent_Policy/
Test failure: #80241
Checklist
Delete any items that are not applicable to this PR.