Upgrade EUI to v29.5.0#80753
Merged
chandlerprall merged 5 commits intoelastic:masterfrom Oct 19, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
jportner
reviewed
Oct 15, 2020
x-pack/plugins/spaces/public/management/edit_space/delete_spaces_button.tsx
Outdated
Show resolved
Hide resolved
cjcenizal
approved these changes
Oct 15, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
ES UI snapshot changes LGTM.
kindsun
approved these changes
Oct 15, 2020
Contributor
kindsun
left a comment
There was a problem hiding this comment.
Maps changes lgtm w/ green CI!
- code review
mshustov
approved these changes
Oct 16, 2020
chrisronline
approved these changes
Oct 16, 2020
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
Stack Monitoring changes LGTM!
flash1293
reviewed
Oct 16, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
KibanaApp changes LGTM, those were only related to the div -> span change. Didn't test locally
jportner
approved these changes
Oct 16, 2020
Contributor
jportner
left a comment
There was a problem hiding this comment.
Security/Spaces changes LGTM!
justinkambic
approved these changes
Oct 16, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Uptime changes LGTM
patrykkopycinski
approved these changes
Oct 16, 2020
Contributor
patrykkopycinski
left a comment
There was a problem hiding this comment.
SIEM/Endpoint changes LGTM!
jasonrhodes
approved these changes
Oct 16, 2020
Member
jasonrhodes
left a comment
There was a problem hiding this comment.
DIVs became SPANs OMG (LGTM)
3d8bd08 to
7465944
Compare
Contributor
💚 Build SucceededMetrics [docs]@kbn/ui-shared-deps asset size
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Oct 19, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 20, 2020
…lout-for-warm-and-cold-tier * 'master' of github.com:elastic/kibana: (126 commits) Add cumulative sum expression function (elastic#80129) [APM] Fix link to trace (elastic#80993) Provide url rewritten in onPreRouting interceptor (elastic#80810) limit renovate to npm packages Fix bug in logs UI link (elastic#80943) [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343) [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list docs test (elastic#81080) Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067) [APM] Fix service map highlighted edge on node select (elastic#80791) Fix typo in toast, slight copy adjustment. (elastic#80843) [Security Solution] reduce optimizer limits (elastic#80997) [maps] 7.10 documentation updates (elastic#79917) [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903) [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033) Upgrade EUI to v29.5.0 (elastic#80753) [Maps] Fix layer-flash when changing style (elastic#80948) [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220) [Enterprise Search] Handle loading state on Credentials page (elastic#80035) [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979) ...
chandlerprall
added a commit
that referenced
this pull request
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades EUI from 29.3 to 29.5. The overwhelming majority of snapshot changes (and the one unit test) are due to EUI's icon mock switching from a
divtospanelastic/eui#4099.29.5.0plusandminusglyphs toEuiIcon(#4111)Bug fixes
EuiIconapp (two-tone) icons (#4104)iconTypeprop to berequiredinEuiButtonIcon(#4106)29.4.0childrenBetweenprop toEuiInMemoryTableto add content between search bar and table (#4103)max-width: 100%toEuiKeyPadMenuto allow it to shrink when its container is smaller than its fixed width ( #4092)keytoEuiComboBoxOptionOptionto allow duplicate labels (#4048)EuiIcontest mock to render asspaninstead ofdiv(#4099)scripts/docker-puppeteeras the new home for test-related Docker images (#4062)Bug fixes
EuiFieldSearchpadding whenisClearablebut has novalue(#4089)