[EuiIcon] Add plus and minus glyphs#4111
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
|
Just a note that the change to all icon files is a result of upgrading |
|
Honestly, I know it goes against our typical glyph making rules, but the 1.5px stroke makes such a small icon so much easier to see. I even checked it on a non-retina screen, and yes, while it's not as "crisp" as the single pixel, it's still bolder and easier to see. |
thompsongl
left a comment
There was a problem hiding this comment.
I'll let @cchaos have final say on the new icons, but the other 400 files changed LGTM 😄
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
Summary
Adds
plusandminusglyphs. This PR contains the option where the stroke width is 1px. I also explored the option of 1.5px stroke width as you'll see in the screenshots below (plus1_5andminus1_5).Fixes #1748
Checklist
- [ ] Props have proper autodocs- [ ] Checked Code Sandbox works for the any docs examples- [x] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes