[EuiFieldSearch] Fix padding when isClearable but no value yet#4089
Merged
cchaos merged 2 commits intoelastic:masterfrom Oct 1, 2020
Merged
[EuiFieldSearch] Fix padding when isClearable but no value yet#4089cchaos merged 2 commits intoelastic:masterfrom
isClearable but no value yet#4089cchaos merged 2 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4089/ |
thompsongl
approved these changes
Oct 1, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
I missed this also. Changes LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to previous PR
Didn't realize that the padding for
isClearablewas being applied even before the button exists. Saw this in Kibana:The search filed cuts off the placeholder too early.
Before
After
And it's still working appropriately when there is a value.
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes