[Monitoring] Fix cluster listing page in how it handles global state#78979
Merged
chrisronline merged 7 commits intoelastic:masterfrom Oct 19, 2020
Merged
[Monitoring] Fix cluster listing page in how it handles global state#78979chrisronline merged 7 commits intoelastic:masterfrom
chrisronline merged 7 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
Contributor
Author
|
@elasticmachine merge upstream |
Zacqary
approved these changes
Oct 19, 2020
Contributor
Zacqary
left a comment
There was a problem hiding this comment.
Tested, can confirm this is working. LGTM
Contributor
Author
|
@elasticmachine merge upstream |
simianhacker
approved these changes
Oct 19, 2020
Member
simianhacker
left a comment
There was a problem hiding this comment.
LGTM (on behalf of @Zacqary)
jasonrhodes
approved these changes
Oct 19, 2020
Member
jasonrhodes
left a comment
There was a problem hiding this comment.
Approving on behalf of @Zacqary :)
Contributor
Author
|
Woah, easy folks! Not all at once! |
Contributor
|
I'd like to also approve this on behalf of myself |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 19, 2020
…lastic#78979) * Properly unset global state on the listing page * Fix how we handle global state in getSafeForExternalLink * Fix breadcrumbs for clusters link * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 19, 2020
…lastic#78979) * Properly unset global state on the listing page * Fix how we handle global state in getSafeForExternalLink * Fix breadcrumbs for clusters link * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Oct 19, 2020
…78979) (#81049) * Properly unset global state on the listing page * Fix how we handle global state in getSafeForExternalLink * Fix breadcrumbs for clusters link * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Oct 19, 2020
…78979) (#81048) * Properly unset global state on the listing page * Fix how we handle global state in getSafeForExternalLink * Fix breadcrumbs for clusters link * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
Author
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 20, 2020
…lout-for-warm-and-cold-tier * 'master' of github.com:elastic/kibana: (126 commits) Add cumulative sum expression function (elastic#80129) [APM] Fix link to trace (elastic#80993) Provide url rewritten in onPreRouting interceptor (elastic#80810) limit renovate to npm packages Fix bug in logs UI link (elastic#80943) [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343) [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list docs test (elastic#81080) Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067) [APM] Fix service map highlighted edge on node select (elastic#80791) Fix typo in toast, slight copy adjustment. (elastic#80843) [Security Solution] reduce optimizer limits (elastic#80997) [maps] 7.10 documentation updates (elastic#79917) [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903) [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033) Upgrade EUI to v29.5.0 (elastic#80753) [Maps] Fix layer-flash when changing style (elastic#80948) [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220) [Enterprise Search] Handle loading state on Credentials page (elastic#80035) [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #78824
On the cluster listing page, we attempt to link to each cluster in way to ensure we actually load that cluster on the cluster overview page, instead of showing whichever cluster is returned first. This is however not working properly, for multiple reasons, but mainly because we are improperly setting global state for the
cluster_uuidwhile on the listing page.This PR ensure we do not do that, and fixes a hole in the
getSafeForExternalLinkcode to properly use any provided query string parameters.To test, start two separate clusters and connect Kibana to one of them through a remote cluster connection. Ensure you see them both in the cluster listing page. Then, click on one and ensure that one is loaded on the cluster overview page. Then go back to the listing page, and click the other. Make sure you can properly switch between the two.