[Enterprise Search] Handle loading state on Credentials page#80035
Merged
JasonStoltz merged 3 commits intoelastic:masterfrom Oct 19, 2020
Merged
[Enterprise Search] Handle loading state on Credentials page#80035JasonStoltz merged 3 commits intoelastic:masterfrom
JasonStoltz merged 3 commits intoelastic:masterfrom
Conversation
cee-chen
reviewed
Oct 9, 2020
Comment on lines
+67
to
+69
| {!!dataLoading ? ( | ||
| <EuiLoadingContent lines={3} /> | ||
| ) : ( |
Contributor
There was a problem hiding this comment.
Question on this - do we really want to show a loading skeleton for the Endpoint panel since it's not really showing any dynamic info? The endpoint is available immediately on page load, maybe we should just opt to show it immediately?
Member
Author
There was a problem hiding this comment.
Ah, I just assumed we had to wait for it to be available. But you're right, the plugin won't load until that data is fetched, so we can lose this.
Member
Author
|
@constancecchen Updated, take a look when you can please. |
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts·ts.Actions and Triggers app alerts should delete all selectionStandard OutStack TraceMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
JasonStoltz
added a commit
to JasonStoltz/kibana
that referenced
this pull request
Oct 19, 2020
JasonStoltz
added a commit
that referenced
this pull request
Oct 19, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 20, 2020
…lout-for-warm-and-cold-tier * 'master' of github.com:elastic/kibana: (126 commits) Add cumulative sum expression function (elastic#80129) [APM] Fix link to trace (elastic#80993) Provide url rewritten in onPreRouting interceptor (elastic#80810) limit renovate to npm packages Fix bug in logs UI link (elastic#80943) [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343) [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list docs test (elastic#81080) Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067) [APM] Fix service map highlighted edge on node select (elastic#80791) Fix typo in toast, slight copy adjustment. (elastic#80843) [Security Solution] reduce optimizer limits (elastic#80997) [maps] 7.10 documentation updates (elastic#79917) [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903) [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033) Upgrade EUI to v29.5.0 (elastic#80753) [Maps] Fix layer-flash when changing style (elastic#80948) [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220) [Enterprise Search] Handle loading state on Credentials page (elastic#80035) [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles the loading state for the Credentials page
Checklist
Delete any items that are not applicable to this PR.
~
For maintainers