[EuiButtonIcon] change iconType prop to required#4106
Merged
cchaos merged 12 commits intoelastic:masterfrom Oct 14, 2020
Merged
[EuiButtonIcon] change iconType prop to required#4106cchaos merged 12 commits intoelastic:masterfrom
cchaos merged 12 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
snide
reviewed
Oct 5, 2020
Contributor
|
jenkins test this |
chandlerprall
suggested changes
Oct 5, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Two very small asks, otherwise this looks great.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4106/ |
Contributor
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4106/ |
Contributor
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4106/ |
chandlerprall
approved these changes
Oct 14, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM, pulled & tested locally including taking manual control of icon props in EuiFieldPassword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4059
EuiFieldPassword'sdualToggleprops to avoid multiple props with same nameChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for accessibility including keyboard-only and screenreader modes