Skip to content

[Security Solution] [Detections] Log message enhancements#78429

Merged
dhurley14 merged 3 commits intoelastic:masterfrom
dhurley14:update-logging
Sep 28, 2020
Merged

[Security Solution] [Detections] Log message enhancements#78429
dhurley14 merged 3 commits intoelastic:masterfrom
dhurley14:update-logging

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

@dhurley14 dhurley14 commented Sep 24, 2020

Summary

adds missing buildRuleMessage to debug logs to display rule id, name, etc. in logs

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dhurley14 dhurley14 self-assigned this Sep 24, 2020
@dhurley14 dhurley14 added Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v7.9.3 v8.0.0 labels Sep 24, 2020
@dhurley14 dhurley14 marked this pull request as ready for review September 24, 2020 14:24
@dhurley14 dhurley14 requested review from a team as code owners September 24, 2020 14:24
rylnd
rylnd approved these changes Sep 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor point about where this function fits within some arguments, but this is a much-appreciated addition!

x-pack/plugins/security_solution/server/lib/detection_engine/signals/bulk_create_ml_signals.ts Outdated
Copy link
Copy Markdown
Contributor

@rylnd rylnd Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: params already includes things like logger and services, why is buildRuleMessage a separate argument here?

Copy link
Copy Markdown
Contributor Author

@dhurley14 dhurley14 Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood catch I'll swap it out.

@dhurley14
Copy link
Copy Markdown
Contributor Author

dhurley14 commented Sep 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dhurley14 dhurley14 merged commit 3f4e9f4 into elastic:master Sep 28, 2020
@dhurley14 dhurley14 deleted the update-logging branch September 28, 2020 19:25
@dhurley14 dhurley14 mentioned this pull request Sep 28, 2020
Merged
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Sep 28, 2020
@dhurley14 @elasticmachine
[Security Solution] [Detections] Log message enhancements (elastic#78429
4d3f378 
)

* adds missing buildRuleMessage to debug logs to display rule id, name, etc. in logs

* add buildRuleMessage fn to params

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@dhurley14 dhurley14 mentioned this pull request Sep 28, 2020
Merged
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Sep 28, 2020
@dhurley14 @elasticmachine
[Security Solution] [Detections] Log message enhancements (elastic#78429
b7151f9 
)

* adds missing buildRuleMessage to debug logs to display rule id, name, etc. in logs

* add buildRuleMessage fn to params

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/search_after_bulk_create.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/single_bulk_create.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/single_search_after.test.ts
dhurley14 added a commit that referenced this pull request Sep 28, 2020
@dhurley14 @elasticmachine
[7.9] [Security Solution] [Detections] Log message enhancements (#78429…
4eefb83 
…) (#78672)

* adds missing buildRuleMessage to debug logs to display rule id, name, etc. in logs

* add buildRuleMessage fn to params

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/search_after_bulk_create.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/single_bulk_create.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/single_search_after.test.ts
dhurley14 added a commit that referenced this pull request Sep 28, 2020
@dhurley14 @elasticmachine
[7.x] [Security Solution] [Detections] Log message enhancements (#78429…
facb3c4 
…) (#78671)

* adds missing buildRuleMessage to debug logs to display rule id, name, etc. in logs

* add buildRuleMessage fn to params

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'add-anomalies-to-timeline' of github.com:phillipb/kiban…
ecee577 
…a into add-anomalies-to-timeline

* 'add-anomalies-to-timeline' of github.com:phillipb/kibana: (89 commits)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  [Enterprise Search] Remove all instances of KibanaContext to Kea store (elastic#78513)
  [ML] DF Analytics creation: ensure job did not fail to start before showing results link (elastic#78200)
  fix createAppNavigationHandler to use `navigateToUrl` (elastic#78583)
  Fixing a11y test failure on discover app (elastic#59975) (elastic#77614)
  [Security Solution] Initiate endpoint package upgrade from security app (elastic#77498)
  [kbn/es] use a basic build process (elastic#78090)
  [kbn/optimizer] fix .json extension handling (elastic#78524)
  Fix APM lodash imports (elastic#78438)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 29, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
4943c44 
* master: (365 commits)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  [Security Solution] Fixes url timeline flaky test (elastic#78556)
  adds retryability feature (elastic#78611)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

@dhurley14 dhurley14

Labels

Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes review v7.9.3 v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhurley14 @kibanamachine @rylnd @elasticmachine