Aligns several module versions across the repository by tylersmalley · Pull Request #78327 · elastic/kibana

tylersmalley · 2020-09-23T17:40:00Z

We're working to bring Kibana to a single package.json. Details and discussion on that decision is at #76412. This PR aligs a handful of dependencies without any breaking changes across the repository.

Before: #76412 (comment)

After:

@elastic/elasticsearch (7.9.0-rc.2,7.9.0-rc.1)
  - package.json@7.9.0-rc.2
  - packages/kbn-es/package.json@7.9.0-rc.1
  - x-pack/plugins/apm/scripts/package.json@7.9.0-rc.1
chalk (^2.4.2,^4.1.0)
  - package.json@^2.4.2
  - x-pack/package.json@^4.1.0
  - packages/kbn-dev-utils/package.json@^4.1.0
  - packages/kbn-es/package.json@^4.1.0
  - packages/kbn-pm/package.json@^4.1.0
  - packages/kbn-test/package.json@^4.1.0
  - packages/kbn-ui-framework/package.json@^4.1.0
react-router (^5.2.0,^3.2.0)
  - package.json@^5.2.0
  - x-pack/package.json@^5.2.0
  - packages/kbn-ui-framework/package.json@^3.2.0
  - packages/kbn-ui-shared-deps/package.json@^5.2.0
rison-node (1.0.2,0.3.1)
  - package.json@1.0.2
  - x-pack/package.json@0.3.1
@types/strip-ansi (^3.0.0,^5.2.1)
  - package.json@^3.0.0
  - packages/kbn-pm/package.json@^3.0.0
  - packages/kbn-test/package.json@^5.2.1
react-redux (^7.2.0,^5.1.2)
  - package.json@^7.2.0
  - x-pack/package.json@^7.2.0
  - packages/kbn-ui-framework/package.json@^5.1.2
redux (^4.0.5,3.7.2)
  - package.json@^4.0.5
  - x-pack/package.json@^4.0.5
  - packages/kbn-ui-framework/package.json@3.7.2
strip-ansi (^3.0.1,^6.0.0,^4.0.0,^5.2.0)
  - package.json@^3.0.1
  - packages/kbn-dev-utils/package.json@^6.0.0
  - packages/kbn-pm/package.json@^4.0.0
  - packages/kbn-test/package.json@^5.2.0
tape (^4.13.0,^5.0.1)
  - package.json@^4.13.0
  - packages/elastic-safer-lodash-set/package.json@^5.0.1
extract-zip (^1.7.0,^2.0.1)
  - x-pack/package.json@^1.7.0
  - packages/kbn-plugin-helpers/package.json@^2.0.1
graphql (^0.13.2,^14.0.0)
  - x-pack/package.json@^0.13.2
  - packages/kbn-release-notes/package.json@^14.0.0
graphql-tag (^2.9.2,^2.10.3)
  - x-pack/package.json@^2.9.2
  - packages/kbn-release-notes/package.json@^2.10.3
@cypress/webpack-preprocessor (^4.1.0,^5.4.1)
  - x-pack/package.json@^4.1.0
  - x-pack/plugins/apm/e2e/package.json@^5.4.1
cypress (5.0.0,^4.9.0)
  - x-pack/package.json@5.0.0
  - x-pack/plugins/apm/e2e/package.json@^4.9.0
ts-loader (^6.0.4,^7.0.5)
  - x-pack/package.json@^6.0.4
  - x-pack/plugins/apm/e2e/package.json@^7.0.5
inquirer (^7.3.3,^1.2.2)
  - packages/kbn-plugin-generator/package.json@^7.3.3
  - packages/kbn-plugin-helpers/package.json@^1.2.2
ora (^1.4.0,^4.0.4)
  - packages/kbn-pm/package.json@^1.4.0
  - x-pack/plugins/apm/e2e/package.json@^4.0.4

tylersmalley · 2020-09-23T18:23:11Z

x-pack/plugins/apm/e2e/package.json

This package is for E2E tests, we should not ship these dependencies.

tylersmalley · 2020-09-23T19:49:28Z

packages/kbn-es/package.json

3.0.0 just drops IE support

tylersmalley · 2020-09-23T19:51:06Z

packages/kbn-ui-framework/package.json

🤦‍♂️

Do the ui-framework docs still work with this change?

That's a good point - We have a discussion to remove ui-framework entirely in #46410 (comment).

I will revert this line, and create another PR to remove all but the assets we're currently relying on for ui-framework so we're not in some half working state.

tylersmalley · 2020-09-23T19:51:39Z

x-pack/package.json

Was already in the dependencies list.

tylersmalley · 2020-09-24T14:45:37Z

@elasticmachine merge upstream

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

elasticmachine · 2020-09-24T21:29:30Z

Pinging @elastic/kibana-operations (Team:Operations)

elasticmachine · 2020-09-24T21:30:49Z

Pinging @elastic/apm-ui (Team:apm)

smith

APM changes look good.

mshustov

ok for the platform changes

mistic

LGTM

tylersmalley · 2020-09-28T18:10:25Z

@elasticmachine merge upstream

kibanamachine · 2020-09-28T19:45:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7a75fc6

Metrics [docs]

async chunks size

id	value	diff	baseline
enterpriseSearch	489.3KB	+12.0B	489.2KB

page load bundle size

id	value	diff	baseline
upgradeAssistant	64.7KB	+6.0B	64.7KB

distributable file count

id	value	diff	baseline
default	45665	-6	45671

History

💔 Build #77561 failed 1d594e7
💚 Build #76976 succeeded 5ced163
💔 Build #76958 failed 3e2dfee179177e227673e01259b9e26861b74d95
💛 Build #76733 was flaky 73b1bae01b4b7fd04358322aa22eb9032283172a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal

LGTM! Tested Painless Lab and Index Management settings editor to verify that both the Ace code editor and Monaco code editor still behave as expected.

…a into add-anomalies-to-timeline * 'add-anomalies-to-timeline' of github.com:phillipb/kibana: (89 commits) Aligns several module versions across the repository (elastic#78327) Empty prompt and loading spinner for service map (elastic#78382) Change progress bar to spinner (elastic#78460) [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111) Slim down core bundle (elastic#75912) [Alerting] retry internal OCC calls within alertsClient (elastic#77838) [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656) [Ingest Manager] Ingest setup upgrade (elastic#78081) [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520) fix name without a category or if field end with .text (elastic#78655) [Security Solution] [Detections] Log message enhancements (elastic#78429) [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303) [Enterprise Search] Remove all instances of KibanaContext to Kea store (elastic#78513) [ML] DF Analytics creation: ensure job did not fail to start before showing results link (elastic#78200) fix createAppNavigationHandler to use `navigateToUrl` (elastic#78583) Fixing a11y test failure on discover app (elastic#59975) (elastic#77614) [Security Solution] Initiate endpoint package upgrade from security app (elastic#77498) [kbn/es] use a basic build process (elastic#78090) [kbn/optimizer] fix .json extension handling (elastic#78524) Fix APM lodash imports (elastic#78438) ...

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # package.json # packages/kbn-spec-to-console/package.json # x-pack/package.json # yarn.lock

* master: (365 commits) making expression debug info serializable (elastic#78727) fix lodahs imports in app-arch code (elastic#78582) Make Field a React.lazy export (elastic#78483) [Security Solution] Improves detections tests (elastic#77295) [TSVB] Different field format on different series is ignored (elastic#78138) RFC: Improve saved object migrations (elastic#66056) [Security Solution] Fixes url timeline flaky test (elastic#78556) adds retryability feature (elastic#78611) Aligns several module versions across the repository (elastic#78327) Empty prompt and loading spinner for service map (elastic#78382) Change progress bar to spinner (elastic#78460) [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111) Slim down core bundle (elastic#75912) [Alerting] retry internal OCC calls within alertsClient (elastic#77838) [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656) [Ingest Manager] Ingest setup upgrade (elastic#78081) [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520) fix name without a category or if field end with .text (elastic#78655) [Security Solution] [Detections] Log message enhancements (elastic#78429) [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303) ...

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # package.json # packages/kbn-spec-to-console/package.json # x-pack/package.json # yarn.lock

tylersmalley force-pushed the align-versions branch from 18264d3 to f1824d3 Compare September 23, 2020 18:05

tylersmalley commented Sep 23, 2020

View reviewed changes

tylersmalley force-pushed the align-versions branch 3 times, most recently from f795ff2 to bb2bc5f Compare September 23, 2020 19:45

tylersmalley commented Sep 23, 2020

View reviewed changes

packages/kbn-es/package.json Outdated

Copy link
Copy Markdown

Member Author

tylersmalley Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0.0 just drops IE support

tylersmalley commented Sep 23, 2020

View reviewed changes

x-pack/package.json Outdated

Copy link
Copy Markdown

Member Author

tylersmalley Sep 23, 2020 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was already in the dependencies list.

tylersmalley force-pushed the align-versions branch 2 times, most recently from 2aa3ca5 to 73b1bae Compare September 23, 2020 21:19

elastic deleted a comment from kibanamachine Sep 23, 2020

Aligns several module versions across the repository

5ced163

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley force-pushed the align-versions branch from 3e2dfee to 5ced163 Compare September 24, 2020 15:11

tylersmalley added backport:skip This PR does not require backporting Team:Operations Kibana-Operations Team v7.10.0 v8.0.0 labels Sep 24, 2020

tylersmalley marked this pull request as ready for review September 24, 2020 21:29

tylersmalley requested a review from a team September 24, 2020 21:29

tylersmalley requested review from a team as code owners September 24, 2020 21:29

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 24, 2020

mattkime approved these changes Sep 24, 2020

View reviewed changes

smith approved these changes Sep 24, 2020

View reviewed changes

mshustov approved these changes Sep 25, 2020

View reviewed changes

mistic approved these changes Sep 28, 2020

View reviewed changes

tylersmalley added the release_note:skip Skip the PR/issue when compiling release notes label Sep 28, 2020

Merge remote-tracking branch 'upstream/master' into align-versions

1d594e7

Merge branch 'master' into align-versions

7a75fc6

cjcenizal approved these changes Sep 28, 2020

View reviewed changes

tylersmalley merged commit da134f3 into elastic:master Sep 28, 2020

tylersmalley mentioned this pull request Sep 29, 2020

[7.x] Aligns several module versions across the repository (#78327) #78714

Merged

mistic mentioned this pull request Sep 29, 2020

chore(NA): assures a single version for the same dependency across the entire project #78825

Merged

Conversation

tylersmalley commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tylersmalley Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

tylersmalley Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

tylersmalley Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

spalger Sep 24, 2020

Choose a reason for hiding this comment

Uh oh!

tylersmalley Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tylersmalley Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Sep 24, 2020

Uh oh!

elasticmachine commented Sep 24, 2020

Uh oh!

elasticmachine commented Sep 24, 2020

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

mshustov left a comment

Choose a reason for hiding this comment

Uh oh!

mistic left a comment

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Sep 28, 2020

Uh oh!

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

page load bundle size

distributable file count

History

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tylersmalley commented Sep 23, 2020 •

edited

Loading

tylersmalley Sep 24, 2020 •

edited

Loading

tylersmalley Sep 23, 2020 •

edited

Loading