Fixing a11y test failure on discover app (https://github.com/elastic/kibana/issues/59975)#77614
Merged
bhavyarm merged 13 commits intoelastic:masterfrom Sep 28, 2020
Merged
Fixing a11y test failure on discover app (https://github.com/elastic/kibana/issues/59975)#77614bhavyarm merged 13 commits intoelastic:masterfrom
bhavyarm merged 13 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@LeeDr resolved. Thanks for looking it over. |
myasonik
reviewed
Sep 17, 2020
Contributor
myasonik
left a comment
There was a problem hiding this comment.
More broadly, I'm not sure how splitting the tests out into multiple files will address the test failure? Won't we still get it but from a different file?
Contributor
Author
|
@myasonik we didn't need the load new search test because I was already testing the same screen in a different test. Plus the error was not a11y error but because of implementation changes - data test subject not being found. Thanks! |
Contributor
Author
|
@elasticmachine merge upstream |
myasonik
approved these changes
Sep 24, 2020
Contributor
Author
|
@LeeDr I have addressed your comments here. Do I need an LGTM from you again? Thanks! |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
LeeDr
approved these changes
Sep 28, 2020
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - only code review and Jenkins results
bhavyarm
added a commit
to bhavyarm/kibana
that referenced
this pull request
Sep 28, 2020
scottybollinger
pushed a commit
to scottybollinger/kibana
that referenced
this pull request
Sep 28, 2020
bhavyarm
added a commit
that referenced
this pull request
Sep 28, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 29, 2020
…a into add-anomalies-to-timeline * 'add-anomalies-to-timeline' of github.com:phillipb/kibana: (89 commits) Aligns several module versions across the repository (elastic#78327) Empty prompt and loading spinner for service map (elastic#78382) Change progress bar to spinner (elastic#78460) [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111) Slim down core bundle (elastic#75912) [Alerting] retry internal OCC calls within alertsClient (elastic#77838) [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656) [Ingest Manager] Ingest setup upgrade (elastic#78081) [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520) fix name without a category or if field end with .text (elastic#78655) [Security Solution] [Detections] Log message enhancements (elastic#78429) [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303) [Enterprise Search] Remove all instances of KibanaContext to Kea store (elastic#78513) [ML] DF Analytics creation: ensure job did not fail to start before showing results link (elastic#78200) fix createAppNavigationHandler to use `navigateToUrl` (elastic#78583) Fixing a11y test failure on discover app (elastic#59975) (elastic#77614) [Security Solution] Initiate endpoint package upgrade from security app (elastic#77498) [kbn/es] use a basic build process (elastic#78090) [kbn/optimizer] fix .json extension handling (elastic#78524) Fix APM lodash imports (elastic#78438) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the fix (#59975):
1.Removed unnecessary a11y tests
2.Removed filter actions - they will go in another test
3.Removed dangling context view test - they will go in another test