[QA][Code Coverage] Coverage teams lookup w/o Additional Config by wayneseymour · Pull Request #77111 · elastic/kibana

wayneseymour · 2020-09-09T20:42:08Z

Similar to #74994

However, we are not using a separate config file.

Will resolve #72692

Remove the code that uploaded a team assignment json def, upon every ci run of the code-coverage job.
Add ability to assign teams to all file paths, that are defined in CODEOWNERS (file system crawler).
Also, extend CODEOWNERS definitions to include lines prepended w/ #CC# that only define code coverage team names, not "review alerting" in github.
Integrate this "service" into the code coverage ingestion transforms.

wayneseymour · 2020-09-10T22:40:10Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1102/

wayneseymour · 2020-09-10T22:40:34Z

The code needs some cleanup still, but let's see how the current build goes first.

wayneseymour · 2020-09-11T02:55:22Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1104/

wayneseymour · 2020-09-11T10:10:37Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1105/

dmlemeshko · 2020-09-14T09:26:48Z

@elasticmachine merge upstream

dmlemeshko

@wayneseymour Great work! What will happen if team assignment file is empty?

src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js

src/dev/code_coverage/ingest_coverage/transforms.js

wayneseymour · 2020-09-14T17:25:16Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1116/

LeeDr · 2020-09-14T21:56:41Z

From the most recent Code Coverage job it looks like the paths covered in the existing CODEOWNERS file are getting team assignments. I think we need to add as many of the additional file paths to team relationships into CODEOWNERS as we can to fully test this PR.

spalger · 2020-09-14T22:46:02Z

I think we need to add as many of the additional file paths to team relationships into CODEOWNERS as we can to fully test this PR.

This is the problem with coupling the two configs together, I don't think it's a good idea to force code owner definitions for teams who don't want to force review of specific code, but maybe I'm being short sighted.

LeeDr · 2020-09-14T22:49:49Z

@spalger it won't cause any additional code reviews. The additional paths will be ignored as comments by github.

spalger · 2020-09-14T23:02:36Z

Alright, I'm fine giving that a shot

wayneseymour · 2020-09-15T18:16:09Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1123/

wayneseymour · 2020-09-15T21:26:13Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1126/

wayneseymour · 2020-09-23T20:55:29Z

src/dev/code_coverage/ingest_coverage/transforms.js

+  );
+
+  return pipe(
+    await grepAndXform(),


@rylnd I went ahead with your first proposition. Honestly, it was simply easier to grok :)

wayneseymour · 2020-09-23T23:24:23Z

@elastic/kibana-operations I'd really appreciate a review, particularly on the CODEOWNERS file. @dmlemeshko has already reviewed the js code.

wayneseymour · 2020-09-24T19:26:38Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1162/

wayneseymour · 2020-09-24T22:36:16Z

@elasticmachine merge upstream

wayneseymour · 2020-09-24T23:16:56Z

@elasticmachine merge upstream

wayneseymour · 2020-09-25T04:57:40Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1164/

wayneseymour · 2020-09-25T15:31:32Z

@elasticmachine merge upstream

wayneseymour · 2020-09-25T15:35:34Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1166/

wayneseymour · 2020-09-25T21:19:29Z

@elasticmachine merge upstream

wayneseymour · 2020-09-27T17:31:17Z

@elasticmachine merge upstream

wayneseymour · 2020-09-27T17:31:43Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1174/

wayneseymour · 2020-09-28T00:42:21Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1176/

wayneseymour · 2020-09-28T00:45:59Z

https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/128/

spalger

The operations specific changes look good, couple nitpicks

vars/kibanaTeamAssign.groovy

scripts/generate_team_assignments.js

so we can lookup stuff in gcp during errors.

…s-lookup-without-ownership-config

wayneseymour · 2020-09-28T18:52:17Z

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1180/

kibanamachine · 2020-09-28T20:27:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 396d4ce

Metrics [docs]

✅ unchanged

History

💔 Build #77563 failed 4068ccd
💔 Build #77493 failed 12d01e2
💔 Build #77468 failed e6b5026
💚 Build #77267 succeeded 48e3907
💚 Build #77262 succeeded 8b41b6b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…a into add-anomalies-to-timeline * 'add-anomalies-to-timeline' of github.com:phillipb/kibana: (89 commits) Aligns several module versions across the repository (elastic#78327) Empty prompt and loading spinner for service map (elastic#78382) Change progress bar to spinner (elastic#78460) [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111) Slim down core bundle (elastic#75912) [Alerting] retry internal OCC calls within alertsClient (elastic#77838) [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656) [Ingest Manager] Ingest setup upgrade (elastic#78081) [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520) fix name without a category or if field end with .text (elastic#78655) [Security Solution] [Detections] Log message enhancements (elastic#78429) [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303) [Enterprise Search] Remove all instances of KibanaContext to Kea store (elastic#78513) [ML] DF Analytics creation: ensure job did not fail to start before showing results link (elastic#78200) fix createAppNavigationHandler to use `navigateToUrl` (elastic#78583) Fixing a11y test failure on discover app (elastic#59975) (elastic#77614) [Security Solution] Initiate endpoint package upgrade from security app (elastic#77498) [kbn/es] use a basic build process (elastic#78090) [kbn/optimizer] fix .json extension handling (elastic#78524) Fix APM lodash imports (elastic#78438) ...

* master: (365 commits) making expression debug info serializable (elastic#78727) fix lodahs imports in app-arch code (elastic#78582) Make Field a React.lazy export (elastic#78483) [Security Solution] Improves detections tests (elastic#77295) [TSVB] Different field format on different series is ignored (elastic#78138) RFC: Improve saved object migrations (elastic#66056) [Security Solution] Fixes url timeline flaky test (elastic#78556) adds retryability feature (elastic#78611) Aligns several module versions across the repository (elastic#78327) Empty prompt and loading spinner for service map (elastic#78382) Change progress bar to spinner (elastic#78460) [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111) Slim down core bundle (elastic#75912) [Alerting] retry internal OCC calls within alertsClient (elastic#77838) [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656) [Ingest Manager] Ingest setup upgrade (elastic#78081) [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520) fix name without a category or if field end with .text (elastic#78655) [Security Solution] [Detections] Log message enhancements (elastic#78429) [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303) ...

kibanamachine · 2020-09-30T21:34:40Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77111 or prevent reminders by adding the backport:skip label.

wayneseymour self-assigned this Sep 9, 2020

wayneseymour added release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0 labels Sep 9, 2020

wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch from 9b64852 to e4a82dc Compare September 10, 2020 21:28

wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch 4 times, most recently from 5343e0b to 636f4d3 Compare September 11, 2020 02:49

wayneseymour marked this pull request as ready for review September 11, 2020 02:55

wayneseymour requested review from a team as code owners September 11, 2020 02:55

wayneseymour requested a review from dmlemeshko September 11, 2020 09:53

wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch from 636f4d3 to 6d0e246 Compare September 11, 2020 10:05

dmlemeshko reviewed Sep 14, 2020

View reviewed changes

src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js Outdated Show resolved Hide resolved

src/dev/code_coverage/ingest_coverage/transforms.js Show resolved Hide resolved

wayneseymour requested review from dmlemeshko and tylersmalley September 14, 2020 20:06

wayneseymour mentioned this pull request Sep 14, 2020

[QA][Code Coverage] Coverage teams lookup less unknowns #77414

Closed

wayneseymour commented Sep 23, 2020

View reviewed changes

spalger approved these changes Sep 28, 2020

View reviewed changes

vars/kibanaTeamAssign.groovy Outdated Show resolved Hide resolved

scripts/generate_team_assignments.js Outdated Show resolved Hide resolved

wayneseymour added 5 commits September 28, 2020 12:13

Merge master

30b9100

Add print statement of the canonical timestamp,

d92af0c

so we can lookup stuff in gcp during errors.

Merge branch 'master' of github.com:elastic/kibana into coverage-team…

ee5a532

…s-lookup-without-ownership-config

Merge branch 'master' of github.com:elastic/kibana into coverage-team…

6f3f1da

…s-lookup-without-ownership-config

CR fixups

396d4ce

wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch from 4068ccd to 396d4ce Compare September 28, 2020 18:49

wayneseymour merged commit 3a73e0b into master Sep 28, 2020

wayneseymour deleted the coverage-teams-lookup-without-ownership-config branch September 28, 2020 21:27

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2020

LeeDr added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Sep 30, 2020

Conversation

wayneseymour commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wayneseymour commented Sep 10, 2020

Uh oh!

wayneseymour commented Sep 10, 2020

Uh oh!

wayneseymour commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wayneseymour commented Sep 11, 2020

Uh oh!

dmlemeshko commented Sep 14, 2020

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wayneseymour commented Sep 14, 2020

Uh oh!

LeeDr commented Sep 14, 2020

Uh oh!

spalger commented Sep 14, 2020

Uh oh!

LeeDr commented Sep 14, 2020

Uh oh!

spalger commented Sep 14, 2020

Uh oh!

wayneseymour commented Sep 15, 2020

Uh oh!

wayneseymour commented Sep 15, 2020

Uh oh!

wayneseymour Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

wayneseymour commented Sep 23, 2020

Uh oh!

wayneseymour commented Sep 24, 2020

Uh oh!

wayneseymour commented Sep 24, 2020

Uh oh!

wayneseymour commented Sep 24, 2020

Uh oh!

wayneseymour commented Sep 25, 2020

Uh oh!

wayneseymour commented Sep 25, 2020

Uh oh!

wayneseymour commented Sep 25, 2020

Uh oh!

wayneseymour commented Sep 25, 2020

Uh oh!

wayneseymour commented Sep 27, 2020

Uh oh!

wayneseymour commented Sep 27, 2020

Uh oh!

wayneseymour commented Sep 28, 2020

Uh oh!

wayneseymour commented Sep 28, 2020

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wayneseymour commented Sep 28, 2020

Uh oh!

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

kibanamachine commented Sep 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

wayneseymour commented Sep 9, 2020 •

edited

Loading

wayneseymour commented Sep 11, 2020 •

edited

Loading