[TSVB] Different field format on different series is ignored by DianaDerevyankina · Pull Request #78138 · elastic/kibana

DianaDerevyankina · 2020-09-22T11:07:08Z

Closes #74951
Closes #78426

To fix incorrect tooltip and legend displaying added tickFormatter through decorators to each series settings instead of setting the only one for axis.
To change the Y-axis captions its formatter now returns a simple value instead of first series formatter.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

Closes elastic#74951

sulemanof

LGTM! 👍
Tested locally in Chrome, works as expected

elasticmachine · 2020-09-23T13:00:08Z

Pinging @elastic/kibana-app (Team:KibanaApp)

nickofthyme

Nice! Code changes LGTM.

nickofthyme · 2020-09-23T16:50:13Z

One thing to note is that when no axis.tickFormat is provided it will use the first series.tickFormat. In this case we may want to add a generic axis tick formatter with just the value.

stratoula · 2020-09-24T09:09:13Z

@elasticmachine merge upstream

stratoula

Tested in Chrome. LGTM 🎉

… the first series

… there's only one series

stratoula · 2020-09-28T09:34:06Z

@elasticmachine merge upstream

kibanamachine · 2020-09-28T11:06:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1df5b2f

History

💚 Build #77205 succeeded 101050e
💚 Build #76930 succeeded 33c32e9
💚 Build #76838 succeeded 24b77ef
💚 Build #76131 succeeded e19399a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…#78138) * [TSVB] Different field format on different series is ignored Closes elastic#74951 * Replace formatter of Y axis with simple value instead of formatter of the first series * Add a condition to Y-axis tickFormatter to display formatted value if there's only one series Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (365 commits) making expression debug info serializable (elastic#78727) fix lodahs imports in app-arch code (elastic#78582) Make Field a React.lazy export (elastic#78483) [Security Solution] Improves detections tests (elastic#77295) [TSVB] Different field format on different series is ignored (elastic#78138) RFC: Improve saved object migrations (elastic#66056) [Security Solution] Fixes url timeline flaky test (elastic#78556) adds retryability feature (elastic#78611) Aligns several module versions across the repository (elastic#78327) Empty prompt and loading spinner for service map (elastic#78382) Change progress bar to spinner (elastic#78460) [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111) Slim down core bundle (elastic#75912) [Alerting] retry internal OCC calls within alertsClient (elastic#77838) [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656) [Ingest Manager] Ingest setup upgrade (elastic#78081) [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520) fix name without a category or if field end with .text (elastic#78655) [Security Solution] [Detections] Log message enhancements (elastic#78429) [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303) ...

…#78730) * [TSVB] Different field format on different series is ignored Closes #74951 * Replace formatter of Y axis with simple value instead of formatter of the first series * Add a condition to Y-axis tickFormatter to display formatted value if there's only one series Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…-to-timeline * 'master' of github.com:elastic/kibana: (22 commits) update apm index pattern (elastic#78732) 78024: move transform out of dataset (elastic#78216) [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695) [Discover] Make _source field not clickable (elastic#78698) [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685) [APM] Review feedback from distribution + transaction metrics (elastic#78752) [Ingest pipelines] Add ability to stop pipeline simulation (elastic#78183) [CSM] Fix core vital legend background (elastic#78273) [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481) fix lodash imports (elastic#78456) [Maps] Add layer type preview icons (elastic#78650) [APM] Use transaction metrics for distribution charts (elastic#78484) [Uptime] Ml anomaly alert edit (elastic#76909) [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745) making expression debug info serializable (elastic#78727) fix lodahs imports in app-arch code (elastic#78582) Make Field a React.lazy export (elastic#78483) [Security Solution] Improves detections tests (elastic#77295) [TSVB] Different field format on different series is ignored (elastic#78138) RFC: Improve saved object migrations (elastic#66056) ...

[TSVB] Different field format on different series is ignored

e19399a

Closes elastic#74951

DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Sep 22, 2020

DianaDerevyankina self-assigned this Sep 22, 2020

DianaDerevyankina requested a review from sulemanof September 22, 2020 13:15

sulemanof approved these changes Sep 23, 2020

View reviewed changes

sulemanof requested review from nickofthyme and stratoula September 23, 2020 12:59

sulemanof marked this pull request as ready for review September 23, 2020 12:59

sulemanof requested a review from a team September 23, 2020 12:59

DianaDerevyankina added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Sep 23, 2020

nickofthyme approved these changes Sep 23, 2020

View reviewed changes

Merge branch 'master' into Diana/74951

24b77ef

stratoula approved these changes Sep 24, 2020

View reviewed changes

DianaDerevyankina added v7.10.0 and removed v7.11.0 labels Sep 24, 2020

DianaDerevyankina added 4 commits September 24, 2020 17:00

Merge branch 'DianaDerevyankina' into Diana/74951

35743c4

Replace formatter of Y axis with simple value instead of formatter of…

33c32e9

… the first series

Merge branch 'DianaDerevyankina' into Diana/74951

68b06b9

Add a condition to Y-axis tickFormatter to display formatted value if…

101050e

… there's only one series

DianaDerevyankina force-pushed the Diana/74951 branch from fb76b7f to 101050e Compare September 25, 2020 13:10

Merge branch 'master' into Diana/74951

1df5b2f

alexwizp approved these changes Sep 28, 2020

View reviewed changes

DianaDerevyankina merged commit 6f2fd54 into elastic:master Sep 29, 2020

DianaDerevyankina mentioned this pull request Sep 29, 2020

[7.x] [TSVB] Different field format on different series is ignored (#78138) #78730

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Different field format on different series is ignored#78138

[TSVB] Different field format on different series is ignored#78138
DianaDerevyankina merged 7 commits intoelastic:masterfrom
DianaDerevyankina:Diana/74951

DianaDerevyankina commented Sep 22, 2020 •

edited by stratoula

Loading

Uh oh!

sulemanof left a comment

Uh oh!

elasticmachine commented Sep 23, 2020

Uh oh!

nickofthyme left a comment

Uh oh!

nickofthyme commented Sep 23, 2020 •

edited

Loading

Uh oh!

stratoula commented Sep 24, 2020

Uh oh!

stratoula left a comment

Uh oh!

stratoula commented Sep 28, 2020

Uh oh!

kibanamachine commented Sep 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

DianaDerevyankina commented Sep 22, 2020 • edited by stratoula Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

sulemanof left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 23, 2020

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stratoula commented Sep 24, 2020

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula commented Sep 28, 2020

Uh oh!

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

DianaDerevyankina commented Sep 22, 2020 •

edited by stratoula

Loading

nickofthyme commented Sep 23, 2020 •

edited

Loading