[CSM] Fix core vital legend background#78273
Merged
shahzad31 merged 14 commits intoelastic:masterfrom Sep 29, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
Author
|
@elasticmachine merge upstream |
justinkambic
approved these changes
Sep 28, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Tested in dark mode and UI LGTM.
Left a bunch of comments but they're mostly optional or wellness checks.
x-pack/plugins/apm/public/components/app/RumDashboard/CoreVitals/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/CoreVitals/PaletteLegends.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/CoreVitals/PaletteLegends.tsx
Show resolved
Hide resolved
| <CoreVitalItem | ||
| title={LCP_LABEL} | ||
| value={lcp ? lcp + ' s' : '0'} | ||
| value={formatToSec(lcp, 'ms')} |
Contributor
There was a problem hiding this comment.
Is the output of this function going to be a string presented to the user, or is 'ms' an enumerable string?
If this will cause ms to show to the user make sure the output is translated.
Contributor
Author
There was a problem hiding this comment.
this is already done in another PR
x-pack/plugins/apm/public/components/app/RumDashboard/UXMetrics/index.tsx
Show resolved
Hide resolved
| lcp: ((lcp?.values['50.0'] || 0) / 1000).toFixed(2), | ||
| tbt: tbt?.values['50.0'] || 0, | ||
| fcp: fcp?.values['50.0'] || 0, | ||
| fid: fid?.values['50.0'] ?? 0, |
Contributor
There was a problem hiding this comment.
Could this value have > 2 decimal digits? Ignore if the answer is no, or formatting it as such is no longer important.
Contributor
Author
There was a problem hiding this comment.
it's done in frontend
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 29, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Sep 29, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 29, 2020
…-to-timeline * 'master' of github.com:elastic/kibana: (22 commits) update apm index pattern (elastic#78732) 78024: move transform out of dataset (elastic#78216) [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695) [Discover] Make _source field not clickable (elastic#78698) [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685) [APM] Review feedback from distribution + transaction metrics (elastic#78752) [Ingest pipelines] Add ability to stop pipeline simulation (elastic#78183) [CSM] Fix core vital legend background (elastic#78273) [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481) fix lodash imports (elastic#78456) [Maps] Add layer type preview icons (elastic#78650) [APM] Use transaction metrics for distribution charts (elastic#78484) [Uptime] Ml anomaly alert edit (elastic#76909) [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745) making expression debug info serializable (elastic#78727) fix lodahs imports in app-arch code (elastic#78582) Make Field a React.lazy export (elastic#78483) [Security Solution] Improves detections tests (elastic#77295) [TSVB] Different field format on different series is ignored (elastic#78138) RFC: Improve saved object migrations (elastic#66056) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #77283
Use dark theme var when dark mode is selected for background color.
Added text alongside core vital average, added a popover help icon