[Endpoint] Functional Tests cleanup by paul-tavares · Pull Request #68756 · elastic/kibana

paul-tavares · 2020-06-10T12:21:42Z

Summary

Deleted functinoal_ingest_failure tests (no longer applicable)
Removed Alerts and Resolver tests (no longer applicable)
Renamed functional_endpoint directory to security_solution_endpoint
Moved common page object that were in the endpoint_page to the page_utils
Removed several unnecessary disabled eslint rules under the management code

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-06-10T12:21:44Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-06-10T12:21:46Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

nnamdifrankie · 2020-06-10T13:05:06Z

x-pack/test/security_solution_endpoint/apps/endpoint/index.ts

-
-    // loadTestFile(require.resolve('./alerts'));
-    // loadTestFile(require.resolve('./resolver'));


I think this is good, because it is now part of siem dashboard?

Yes It is part of the Siem

It is in the SIEM but we can remove for now

But Why you deleting all the test

EricDavisX · 2020-06-10T15:54:35Z

@igor was working to bring the Resolver tests back to life... not sure if this needs him and you to sync up or not. I think it might be ok to have the tests maintained for now, even if they hit a hidden route to render the alerts. We could certainly break something and want to know right?

paul-tavares · 2020-06-10T15:59:59Z

@EricDavisX thanks for the comment. I did follow up with the Endpoint response team yesterday and got the ok to remove them, but will resurface that discussion again prior merging this 😃

IgorGuz2000 · 2020-06-10T17:05:15Z

Why Are we deleting all the test for the alerts and resolver

paul-tavares · 2020-06-10T17:39:21Z

@IgorGuz2000 I was deleting them because I did not think they applied anymore. Based on your comment I can bring them back and will create an follow up issue for someone to re-enable them. Sound good?

oatkiller · 2020-06-10T17:41:51Z

I'm working on adding Resolver back into the app. I can take a look at adding tests

…ble)" This reverts commit c5d07e2

dplumlee · 2020-06-10T19:05:56Z

@paul-tavares @IgorGuz2000 I'm unaware of any reasons to keep the alerts functional tests, the page isn't being used and the pieces we do take off to use elsewhere would require us to write new tests anyways. In my opinion, that file is dead code and should be deleted

kibanamachine · 2020-06-10T19:37:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8f58521

History

💚 Build #53009 succeeded e7717a2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Removed several unnecessary disabled eslint rules * moved common pageobject from endpoint_list to page_utils * Rename functional_endpoint to security_solution_endpoint * Delete `functional_endpoint_ingest_failure` no longer applicable # Conflicts: # .github/CODEOWNERS # x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts

* master: (38 commits) Support migrating from reserved feature privileges (elastic#68504) add `preference` field to SavedObjectsFindOptions (elastic#68620) [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505) Cleanup old license overwrites (elastic#68744) Bump TypeScript to v3.9 (elastic#67666) [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727) Fix vega specification parsing (elastic#67963) docs: add more api information (elastic#68717) [APM] Don't show annotations on charts with no data (elastic#68829) [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889) skip flaky suite (elastic#68836) [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640) Index pattern public api => common (elastic#68289) [APM] Lazy-load alert triggers (elastic#68806) [DOCS] Fix table formatting in ingest manager settings (elastic#68824) [Endpoint] Functional Tests cleanup (elastic#68756) revert previous commit which was unintentional Use Github token instead for project assignments [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739) move @kbn/storybook to devDeps (elastic#68791) ...

* [Endpoint] Functional Tests cleanup (#68756) * Removed several unnecessary disabled eslint rules * moved common pageobject from endpoint_list to page_utils * Rename functional_endpoint to security_solution_endpoint * Delete `functional_endpoint_ingest_failure` no longer applicable # Conflicts: # .github/CODEOWNERS # x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts * Sync Endpoint Alerts page objects with master - PR #64704 was never backported, thus this change is needed to ensure build is successful. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

paul-tavares added 7 commits June 9, 2020 11:07

Removed several unnecessary disabled eslint rules

4f5b088

Merge remote-tracking branch 'upstream/master' into task/EMT-446-cleanup

8c00d83

moved common pageobject from endpoint_list to page_utils

99b4a32

Remove Alerts and Resolver functional test (no longer applicable)

c5d07e2

Rename functional_endpoint to security_solution_endpoint

7666c1f

Delete functional_endpoint_ingest_failure no longer applicable

00a5409

Merge remote-tracking branch 'upstream/master' into task/EMT-446-cleanup

e7717a2

paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.9.0 labels Jun 10, 2020

paul-tavares requested review from a team as code owners June 10, 2020 12:21

paul-tavares self-assigned this Jun 10, 2020

paul-tavares changed the title ~~[Endpoint] Functional Tests clean~~ [Endpoint] Functional Tests cleanup Jun 10, 2020

nnamdifrankie reviewed Jun 10, 2020

View reviewed changes

kevinlog approved these changes Jun 10, 2020

View reviewed changes

Revert "Remove Alerts and Resolver functional test (no longer applica…

8f58521

…ble)" This reverts commit c5d07e2

paul-tavares merged commit 577381d into elastic:master Jun 10, 2020

paul-tavares deleted the task/EMT-446-cleanup branch June 10, 2020 21:10

paul-tavares mentioned this pull request Jun 10, 2020

[7.x] [Endpoint] Functional Tests cleanup (#68756) #68822

Merged


		// loadTestFile(require.resolve('./alerts'));
		// loadTestFile(require.resolve('./resolver'));

Conversation

paul-tavares commented Jun 10, 2020

Summary

Checklist

Uh oh!

elasticmachine commented Jun 10, 2020

Uh oh!

elasticmachine commented Jun 10, 2020

Uh oh!

nnamdifrankie Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

IgorGuz2000 Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

IgorGuz2000 Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

IgorGuz2000 Jun 10, 2020

Choose a reason for hiding this comment

Uh oh!

EricDavisX commented Jun 10, 2020

Uh oh!

paul-tavares commented Jun 10, 2020

Uh oh!

IgorGuz2000 commented Jun 10, 2020

Uh oh!

paul-tavares commented Jun 10, 2020

Uh oh!

oatkiller commented Jun 10, 2020

Uh oh!

dplumlee commented Jun 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Jun 10, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dplumlee commented Jun 10, 2020 •

edited

Loading