[APM] Service maps - adds new storybook stories to test out various data sets#68727
Merged
ogupte merged 3 commits intoelastic:masterfrom Jun 11, 2020
Merged
Conversation
- adds story to generate/render service map response data - adds story that renders any service map response json - adds story that renders opbeans test data
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
smith
approved these changes
Jun 10, 2020
| @@ -0,0 +1,327 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
I usually don't think it's necessary to put this in a __stories__ directory, but since we have a lot of examples I can see why we would do it.
| import { iconForNode } from '../icons'; | ||
|
|
||
| storiesOf('app/ServiceMap/Cytoscape', module).add( | ||
| 'example', |
Contributor
There was a problem hiding this comment.
We probably can remove this example since we have other more complete ones now.
| ); | ||
|
|
||
| storiesOf(STORYBOOK_PATH, module).add( | ||
| 'pre-loaded map', |
Contributor
There was a problem hiding this comment.
Maybe a better name might be "map from JSON"
| ); | ||
| }, | ||
| { | ||
| info: { propTables: false, source: false }, |
Contributor
There was a problem hiding this comment.
We could put a text key under info to provide instructions on how to get data in here.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jun 11, 2020
…ata sets (elastic#68727) * - move cytoscape stories-related files to __stories__ - adds story to generate/render service map response data - adds story that renders any service map response json - adds story that renders opbeans test data * added example data for 'Hipster store' and 'Todo app' Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 11, 2020
* master: (38 commits) Support migrating from reserved feature privileges (elastic#68504) add `preference` field to SavedObjectsFindOptions (elastic#68620) [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505) Cleanup old license overwrites (elastic#68744) Bump TypeScript to v3.9 (elastic#67666) [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727) Fix vega specification parsing (elastic#67963) docs: add more api information (elastic#68717) [APM] Don't show annotations on charts with no data (elastic#68829) [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889) skip flaky suite (elastic#68836) [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640) Index pattern public api => common (elastic#68289) [APM] Lazy-load alert triggers (elastic#68806) [DOCS] Fix table formatting in ingest manager settings (elastic#68824) [Endpoint] Functional Tests cleanup (elastic#68756) revert previous commit which was unintentional Use Github token instead for project assignments [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739) move @kbn/storybook to devDeps (elastic#68791) ...
ogupte
added a commit
that referenced
this pull request
Jun 11, 2020
…ata sets (#68727) (#68869) * - move cytoscape stories-related files to __stories__ - adds story to generate/render service map response data - adds story that renders any service map response json - adds story that renders opbeans test data * added example data for 'Hipster store' and 'Todo app' Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #62814