Skip to content

[SIEM][Detections Engine] - Fix reference rule url overflow#68640

Merged
yctercero merged 4 commits intoelastic:masterfrom
yctercero:rule-about-bug
Jun 10, 2020
Merged

[SIEM][Detections Engine] - Fix reference rule url overflow#68640
yctercero merged 4 commits intoelastic:masterfrom
yctercero:rule-about-bug

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

@yctercero yctercero commented Jun 9, 2020

Summary

Rule reference urls, when really long, appear to overflow. The expected behavior is that it would wrap. I thought it was working in the create rule flow and not the details flow, but it was not working on either. The creation flow was simply hiding the overflow. This fixes it by adding word wrap to the urls.

Rule Details

Before

Screen Shot 2020-06-08 at 11 33 02 PM

After

Screen Shot 2020-06-08 at 11 32 30 PM

Rule Creation

Before

Screen Shot 2020-06-09 at 10 27 41 AM

After

Screen Shot 2020-06-09 at 10 26 41 AM

Checklist

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@yctercero
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this one @yctercero! LGTM! 👍

@yctercero yctercero merged commit 9216012 into elastic:master Jun 10, 2020
yctercero added a commit to yctercero/kibana that referenced this pull request Jun 10, 2020
…68640)

### Summary

Rule reference urls, when really long, appear to overflow. The expected behavior is that it would wrap. I thought it was working in the create rule flow and not the details flow, but it was not working on either. The creation flow was simply hiding the overflow. This fixes it by adding word wrap to the urls.
yctercero added a commit that referenced this pull request Jun 11, 2020
…68835)

### Summary

Rule reference urls, when really long, appear to overflow. The expected behavior is that it would wrap. I thought it was working in the create rule flow and not the details flow, but it was not working on either. The creation flow was simply hiding the overflow. This fixes it by adding word wrap to the urls.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 11, 2020
* master: (38 commits)
  Support migrating from reserved feature privileges (elastic#68504)
  add `preference` field to SavedObjectsFindOptions (elastic#68620)
  [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505)
  Cleanup old license overwrites (elastic#68744)
  Bump TypeScript to v3.9 (elastic#67666)
  [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727)
  Fix vega specification parsing (elastic#67963)
  docs: add more api information (elastic#68717)
  [APM] Don't show annotations on charts with no data (elastic#68829)
  [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889)
  skip flaky suite (elastic#68836)
  [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640)
  Index pattern public api => common (elastic#68289)
  [APM] Lazy-load alert triggers (elastic#68806)
  [DOCS] Fix table formatting in ingest manager settings (elastic#68824)
  [Endpoint] Functional Tests cleanup (elastic#68756)
  revert previous commit which was unintentional
  Use Github token instead for project assignments
  [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739)
  move @kbn/storybook to devDeps (elastic#68791)
  ...
@yctercero yctercero deleted the rule-about-bug branch October 14, 2020 12:02
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants