Skip to content

Cleanup old license overwrites#68744

Merged
timroes merged 1 commit intoelastic:masterfrom
timroes:chore/license-cleanup
Jun 11, 2020
Merged

Cleanup old license overwrites#68744
timroes merged 1 commit intoelastic:masterfrom
timroes:chore/license-cleanup

Conversation

@timroes
Copy link
Copy Markdown
Contributor

@timroes timroes commented Jun 10, 2020

Summary

Cleanup old license overwrites, that are no longer required (because we no longer use the dependency, or we updated it to a version that no longer needs that overwrite.

@timroes timroes added chore Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.0.0 v7.9.0 labels Jun 10, 2020
@timroes timroes requested a review from a team as a code owner June 10, 2020 08:21
@elasticmachine

This comment has been minimized.

Sign in to view
@timroes timroes added Team:Operations Kibana-Operations Team and removed Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// labels Jun 10, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 10, 2020

Pinging @elastic/kibana-operations (Team:Operations)

@timroes timroes added the release_note:skip Skip the PR/issue when compiling release notes label Jun 10, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 10, 2020

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-oss-agent / Example plugin functional tests.test/examples/embeddables/adding_children·ts.embeddable explorer creating and adding children Can create a new child

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 8 times on tracked branches: https://github.com/elastic/kibana/issues/58692

[00:00:00]       │
[00:00:30]         └-: embeddable explorer
[00:00:30]           └-> "before all" hook
[00:00:30]           └-> "before all" hook
[00:00:30]             │ debg navigating to embeddableExplorer url: http://localhost:6121/app/embeddableExplorer
[00:00:30]             │ debg navigate to: http://localhost:6121/app/embeddableExplorer
[00:00:30]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1591777324587887091] [.kibana] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:00:31]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591777324587887091] [.kibana/5U9VCr3oS9-STA7TenWs2w] create_mapping
[00:00:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591777324587887091] [.kibana/5U9VCr3oS9-STA7TenWs2w] update_mapping [_doc]
[00:00:32]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591777324587887091] [.kibana/5U9VCr3oS9-STA7TenWs2w] update_mapping [_doc]
[00:00:32]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting application changed to undefined"
[00:00:32]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting application changed to undefined"
[00:00:32]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Error Sending Metrics Report TypeError: Failed to fetch"
[00:00:32]             │ debg browser[INFO] http://localhost:6121/app/embeddableExplorer?_t=1591779321455 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:32]             │
[00:00:32]             │ debg browser[INFO] http://localhost:6121/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:32]             │ debg ... sleep(700) start
[00:00:32]             │ debg ... sleep(700) end
[00:00:32]             │ debg returned from get, calling refresh
[00:00:33]             │ debg browser[INFO] http://localhost:6121/app/embeddableExplorer?_t=1591779321455 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:33]             │
[00:00:33]             │ debg browser[INFO] http://localhost:6121/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:33]             │ debg currentUrl = http://localhost:6121/app/embeddableExplorer
[00:00:33]             │          appUrl = http://localhost:6121/app/embeddableExplorer
[00:00:33]             │ debg TestSubjects.find(kibanaChrome)
[00:00:33]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:35]             │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/plugin/testbed/testbed.plugin.js 172:12 "Testbed plugin set up. uiProp: 'Accessible from client'"
[00:00:35]             │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core/core.entry.js 44011:18 "App [dev_tools] is using deprecated mount context. Use core.getStartServices() instead."
[00:00:35]             │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-06-10T08:55:25Z
[00:00:35]             │        Adding connection to http://localhost:6121/elasticsearch
[00:00:35]             │
[00:00:35]             │      "
[00:00:35]             │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core/core.entry.js 44011:18 "App [management] is using deprecated mount context. Use core.getStartServices() instead."
[00:00:35]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting user-agent."
[00:00:35]             │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/plugin/testbed/testbed.plugin.js 180:12 "Testbed plugin started"
[00:00:35]             │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 951:16 "Reporting application changed to embeddableExplorer"
[00:00:35]             │ debg ... sleep(501) start
[00:00:35]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591777324587887091] [.kibana/5U9VCr3oS9-STA7TenWs2w] update_mapping [_doc]
[00:00:35]             │ debg ... sleep(501) end
[00:00:35]             │ debg in navigateTo url = http://localhost:6121/app/embeddableExplorer
[00:00:35]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:35]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:38]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:41]           └-: creating and adding children
[00:00:41]             └-> "before all" hook
[00:00:41]             └-> "before all" hook
[00:00:41]               │ debg TestSubjects.click(embeddablePanelExamplae)
[00:00:41]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelExamplae"]') with timeout=10000
[00:00:41]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelExamplae"]') with timeout=10000
[00:00:42]             └-> Can create a new child
[00:00:42]               └-> "before each" hook: global before each
[00:00:42]               │ debg TestSubjects.click(embeddablePanelToggleMenuIcon)
[00:00:42]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=10000
[00:00:42]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=10000
[00:00:42]               │ debg TestSubjects.click(embeddablePanelAction-ACTION_ADD_PANEL)
[00:00:42]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelAction-ACTION_ADD_PANEL"]') with timeout=10000
[00:00:42]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelAction-ACTION_ADD_PANEL"]') with timeout=10000
[00:00:42]               │ debg TestSubjects.click(createNew)
[00:00:42]               │ debg Find.clickByCssSelector('[data-test-subj="createNew"]') with timeout=10000
[00:00:42]               │ debg Find.findByCssSelector('[data-test-subj="createNew"]') with timeout=10000
[00:00:42]               │ debg TestSubjects.click(createNew-TODO_EMBEDDABLE)
[00:00:42]               │ debg Find.clickByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:00:42]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:00:52]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:00:52]               │      Wait timed out after 10065ms
[00:00:53]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:03]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:03]               │      Wait timed out after 10024ms
[00:01:03]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:13]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:13]               │      Wait timed out after 10008ms
[00:01:14]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:24]               │ debg --- retry.try failed again with the same message...
[00:01:24]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:34]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:34]               │      Wait timed out after 10028ms
[00:01:35]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:45]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:45]               │      Wait timed out after 10018ms
[00:01:45]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:55]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:55]               │      Wait timed out after 10057ms
[00:01:56]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:06]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:06]               │      Wait timed out after 10050ms
[00:02:06]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:16]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:16]               │      Wait timed out after 10006ms
[00:02:17]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:27]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:27]               │      Wait timed out after 10044ms
[00:02:27]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:37]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:37]               │      Wait timed out after 10029ms
[00:02:38]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:48]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:48]               │      Wait timed out after 10026ms
[00:02:49]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/embeddable explorer creating and adding children Can create a new child.png"
[00:02:49]               │ info Current URL is: http://localhost:6121/app/embeddableExplorer/embeddablePanelExamplae
[00:02:49]               │ info Saving page source to: /dev/shm/workspace/kibana/test/examples/failure_debug/html/embeddable explorer creating and adding children Can create a new child.html
[00:02:49]               └- ✖ fail: "embeddable explorer creating and adding children Can create a new child"
[00:02:49]               │

Stack Trace

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
Wait timed out after 10026ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger
spalger approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes timroes merged commit 2a47411 into elastic:master Jun 11, 2020
@timroes timroes deleted the chore/license-cleanup branch June 11, 2020 09:28
@timroes timroes mentioned this pull request Jun 11, 2020
Merged
timroes pushed a commit to timroes/kibana that referenced this pull request Jun 11, 2020
@timroes
Cleanup old license overwrites (elastic#68744)
421ee7f 
# Conflicts:
#	src/dev/license_checker/config.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 11, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
34b7cf9 
* master: (38 commits)
  Support migrating from reserved feature privileges (elastic#68504)
  add `preference` field to SavedObjectsFindOptions (elastic#68620)
  [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505)
  Cleanup old license overwrites (elastic#68744)
  Bump TypeScript to v3.9 (elastic#67666)
  [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727)
  Fix vega specification parsing (elastic#67963)
  docs: add more api information (elastic#68717)
  [APM] Don't show annotations on charts with no data (elastic#68829)
  [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889)
  skip flaky suite (elastic#68836)
  [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640)
  Index pattern public api => common (elastic#68289)
  [APM] Lazy-load alert triggers (elastic#68806)
  [DOCS] Fix table formatting in ingest manager settings (elastic#68824)
  [Endpoint] Functional Tests cleanup (elastic#68756)
  revert previous commit which was unintentional
  Use Github token instead for project assignments
  [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739)
  move @kbn/storybook to devDeps (elastic#68791)
  ...
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 15, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 15, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 16, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 17, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 17, 2020
timroes pushed a commit that referenced this pull request Jun 17, 2020
@elasticmachine
Cleanup old license overwrites (#68744) (#68881)
d1f3b7e 
# Conflicts:
#	src/dev/license_checker/config.ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz approved these changes

+1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@timroes @elasticmachine @kibanamachine @spalger @jbudz