add preference field to SavedObjectsFindOptions#68620
Merged
pgayvallet merged 2 commits intoelastic:masterfrom Jun 11, 2020
Merged
add preference field to SavedObjectsFindOptions#68620pgayvallet merged 2 commits intoelastic:masterfrom
preference field to SavedObjectsFindOptions#68620pgayvallet merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
Contributor
|
How will GS use this |
Contributor
Author
It's meant to be used by passing a constant |
mshustov
approved these changes
Jun 10, 2020
rudolf
approved these changes
Jun 10, 2020
Contributor
rudolf
left a comment
There was a problem hiding this comment.
From https://www.elastic.co/guide/en/elasticsearch/reference/master/consistent-scoring.html it seems like we might need to add search_type=dfs_query_then_fetch when an index has very few documents (which .kibana often has). But we can play around with it first and add that if it becomes necessary.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 11, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 11, 2020
* master: (38 commits) Support migrating from reserved feature privileges (elastic#68504) add `preference` field to SavedObjectsFindOptions (elastic#68620) [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505) Cleanup old license overwrites (elastic#68744) Bump TypeScript to v3.9 (elastic#67666) [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727) Fix vega specification parsing (elastic#67963) docs: add more api information (elastic#68717) [APM] Don't show annotations on charts with no data (elastic#68829) [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889) skip flaky suite (elastic#68836) [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640) Index pattern public api => common (elastic#68289) [APM] Lazy-load alert triggers (elastic#68806) [DOCS] Fix table formatting in ingest manager settings (elastic#68824) [Endpoint] Functional Tests cleanup (elastic#68756) revert previous commit which was unintentional Use Github token instead for project assignments [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739) move @kbn/storybook to devDeps (elastic#68791) ...
pgayvallet
added a commit
that referenced
this pull request
Jun 11, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Needed for #65222
Add the ES
preferenceoption toSavedObjectsFindOptionsChecklist