New resolver by IgorGuz2000 · Pull Request #64704 · elastic/kibana

IgorGuz2000 · 2020-04-28T21:44:28Z

Functional Test For Resolver controls and table data

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts

x-pack/test/functional_endpoint/page_objects/endpoint_alerts_page.ts

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts

x-pack/plugins/endpoint/public/embeddables/resolver/view/graph_controls.tsx

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts

x-pack/test/functional_endpoint/page_objects/endpoint_alerts_page.ts

EricDavisX

I posted some questions, comments, and potential improvements - if you want to do them now, or later (I hope) or not, I'm ok to merge this if it works. :)

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts

bhavyarm · 2020-04-30T19:05:23Z

@elasticmachine merge upstream

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts

…esolver

kibanamachine · 2020-05-05T02:50:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5f641da

History

💚 Build #45265 succeeded 937d602
💔 Build #45180 failed 5316cec
💔 Build #45085 failed d4a7f61
💔 Build #44838 failed 8facc5a
💔 Build #44771 failed cc212f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2020-05-07T20:58:45Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64704 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-05-08T21:08:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64704 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-05-11T21:18:43Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64704 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-05-12T21:28:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64704 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-05-13T21:38:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64704 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-05-14T21:48:43Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64704 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-05-15T21:58:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64704 or prevent reminders by adding the backport:skip label.

paul-tavares · 2020-06-11T13:17:10Z

FYI - I'm getting backport errors due to this PR not being in 7.x

- PR elastic#64704 was never backported, thus this change is needed to ensure build is successful.

* [Endpoint] Functional Tests cleanup (#68756) * Removed several unnecessary disabled eslint rules * moved common pageobject from endpoint_list to page_utils * Rename functional_endpoint to security_solution_endpoint * Delete `functional_endpoint_ingest_failure` no longer applicable # Conflicts: # .github/CODEOWNERS # x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts * Sync Endpoint Alerts page objects with master - PR #64704 was never backported, thus this change is needed to ensure build is successful. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* New commit * New commit adding data-test-subj to controls * Final commit for the resolver tests * Final commit for the resolver tests * Final commit for the resolver tests * Final commit for the resolver tests * Final commit for the resolver tests * Removed sleep statements and added "WaitForTableToHaveData" * Removed sleep statements and added "WaitForTableToHaveData" * Fixed type check and modified style parsing * Removed window resize * Fixed style type errors * Removed unnecessary sleeps and added verifications for Nodes location * Removed unnecessary sleeps and added verifications for Nodes location * Merge branch 'master' of https://github.com/elastic/kibana into new_resolver * Merge branch 'master' of https://github.com/elastic/kibana into new_resolver * Merge branch 'master' of https://github.com/elastic/kibana into new_resolver * Added resize the window for PAss the test * Added resize the window for PAss the test * Added resize the window for PAss the test * Added resize the window for PAss the test * Added resize the window for PAss the test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/endpoint/public/embeddables/resolver/view/graph_controls.tsx # x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx # x-pack/test/functional_endpoint/apps/endpoint/index.ts # x-pack/test/functional_endpoint/page_objects/endpoint_alerts_page.ts

IgorGuz2000 added 7 commits April 22, 2020 11:36

New commit

5ba5301

New commit adding data-test-subj to controls

9e1fd76

Final commit for the resolver tests

553d3b4

Final commit for the resolver tests

91789a9

Final commit for the resolver tests

c00e89b

Final commit for the resolver tests

c5c960d

Final commit for the resolver tests

99719b9

IgorGuz2000 requested review from achuguy, bkimmel and kqualters-elastic April 28, 2020 21:44

IgorGuz2000 requested a review from a team as a code owner April 28, 2020 21:44

EricDavisX reviewed Apr 28, 2020

View reviewed changes

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts Outdated Show resolved Hide resolved

IgorGuz2000 added 2 commits April 28, 2020 17:38

Removed sleep statements and added "WaitForTableToHaveData"

48bc812

Removed sleep statements and added "WaitForTableToHaveData"

2952d76

EricDavisX reviewed Apr 29, 2020

View reviewed changes

x-pack/test/functional_endpoint/page_objects/endpoint_alerts_page.ts Outdated Show resolved Hide resolved

EricDavisX reviewed Apr 29, 2020

View reviewed changes

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts Outdated Show resolved Hide resolved

EricDavisX reviewed Apr 29, 2020

View reviewed changes

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts Outdated Show resolved Hide resolved

EricDavisX reviewed Apr 29, 2020

View reviewed changes

x-pack/plugins/endpoint/public/embeddables/resolver/view/graph_controls.tsx Show resolved Hide resolved

EricDavisX reviewed Apr 29, 2020

View reviewed changes

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts Outdated Show resolved Hide resolved

EricDavisX reviewed Apr 29, 2020

View reviewed changes

x-pack/test/functional_endpoint/page_objects/endpoint_alerts_page.ts Show resolved Hide resolved

EricDavisX approved these changes Apr 29, 2020

View reviewed changes

Fixed type check and modified style parsing

e4592b0

IgorGuz2000 requested a review from a team as a code owner April 29, 2020 17:38

IgorGuz2000 added 2 commits April 29, 2020 10:44

Removed window resize

90dae6b

Fixed style type errors

6ad7192

EricDavisX reviewed Apr 29, 2020

View reviewed changes

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts Show resolved Hide resolved

IgorGuz2000 added 2 commits April 29, 2020 18:12

Removed unnecessary sleeps and added verifications for Nodes location

1201e32

Removed unnecessary sleeps and added verifications for Nodes location

49ebc5a

Merge branch 'master' into new_resolver

dba16cc

dmlemeshko reviewed Apr 30, 2020

View reviewed changes

x-pack/test/functional_endpoint/apps/endpoint/resolver.ts Show resolved Hide resolved

IgorGuz2000 added 11 commits April 30, 2020 20:43

Merge branch 'master' of https://github.com/elastic/kibana into new_r…

b4533b2

…esolver

Merge remote-tracking branch 'origin/new_resolver' into new_resolver

9f1afa1

Merge remote-tracking branch 'upstream/master' into new_resolver

52a2205

Merge branch 'master' of https://github.com/elastic/kibana into new_r…

8100444

…esolver

Merge branch 'master' of https://github.com/elastic/kibana into new_r…

140509d

…esolver

Added resize the window for PAss the test

cc212f7

Added resize the window for PAss the test

8facc5a

Merge remote-tracking branch 'upstream/master' into new_resolver

d4a7f61

Added resize the window for PAss the test

5316cec

Added resize the window for PAss the test

937d602

Added resize the window for PAss the test

5f641da

IgorGuz2000 merged commit 4302161 into elastic:master May 5, 2020

IgorGuz2000 deleted the new_resolver branch May 6, 2020 16:43

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 7, 2020

IgorGuz2000 added the backport:skip This PR does not require backporting label May 18, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 18, 2020

paul-tavares added a commit to paul-tavares/kibana that referenced this pull request Jun 12, 2020

Sync Endpoint Alerts page objects with master

62c0005

- PR elastic#64704 was never backported, thus this change is needed to ensure build is successful.

IgorGuz2000 mentioned this pull request Sep 21, 2020

[7.x] New resolver (#64704) #78052

Closed

Conversation

IgorGuz2000 commented Apr 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Functional Test For Resolver controls and table data

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EricDavisX left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bhavyarm commented Apr 30, 2020

Uh oh!

Uh oh!

kibanamachine commented May 5, 2020

💚 Build Succeeded

History

Uh oh!

kibanamachine commented May 7, 2020

Uh oh!

kibanamachine commented May 8, 2020

Uh oh!

kibanamachine commented May 11, 2020

Uh oh!

kibanamachine commented May 12, 2020

Uh oh!

kibanamachine commented May 13, 2020

Uh oh!

kibanamachine commented May 14, 2020

Uh oh!

kibanamachine commented May 15, 2020

Uh oh!

paul-tavares commented Jun 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

IgorGuz2000 commented Apr 28, 2020 •

edited

Loading