Merged
Conversation
f40f13f to
04a6a25
Compare
9c7513b to
294f83f
Compare
Contributor
Author
|
@elasticmachine merge upstream |
sorenlouv
reviewed
Mar 2, 2020
Contributor
There was a problem hiding this comment.
Is it necessary to check whether numInstances is defined?
Suggested change
| const showBadgeRow = frameworkName || (numInstances && numInstances > 1); | |
| const showBadgeRow = frameworkName || numInstances > 1; |
Contributor
Author
There was a problem hiding this comment.
Updated in 946f185. Also removed the undefined check on line 125. I think it was optional at one point. Thanks for catching!
Add icons as described in elastic#56235. Also: * Add double-border and ghost "shadow" on nodes * Add framework name capability to popover metrics
b16ed04 to
946f185
Compare
sorenlouv
approved these changes
Mar 2, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Mar 2, 2020
Add icons as described in elastic#56235. Also: * Add double-border and ghost "shadow" on nodes * Add framework name capability to popover metrics
smith
added a commit
that referenced
this pull request
Mar 3, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2020
* master: (26 commits) [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627) Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876) [Maps] direct Discover "visualize" to open Maps application (elastic#58549) Disallow duplicate percentiles (elastic#57444) (elastic#58299) removing references to visTypes uiExports (elastic#58337) [SIEM] Default the Timeline events filter to show All events (elastic#58953) [Remote clusters] Add indexManagement as required plugin (elastic#58915) [DOCS] Rework of main get started page (elastic#58260) [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348) [Endpoint] add resolver middleware (elastic#58288) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2020
…s/kibana into alerting/fix-flaky-instance-test * 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add icons as described in #56235.
Also: