removing references to visTypes uiExports#58337
Merged
ppisljar merged 11 commits intoelastic:masterfrom Mar 2, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
streamich
approved these changes
Feb 24, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Feb 26, 2020
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
code review of maps/* and tested Maps in chrome. lgtm, thx!
d92380e to
db86d92
Compare
flash1293
requested changes
Feb 27, 2020
| import { FormatFactory } from './legacy_imports'; | ||
| import { IEmbeddableSetup, IEmbeddableStart } from '../../../../../src/plugins/embeddable/public'; | ||
| import { EditorFrameStart } from './types'; | ||
| import { setup as visualizations } from '../../../../../src/legacy/core_plugins/visualizations/public/np_ready/public/legacy'; |
Contributor
There was a problem hiding this comment.
Please move this import to legacy.ts and pass it in via the setup call to keep the shim clean.
flash1293
approved these changes
Feb 27, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Kibana App changes LGTM, didn't test locally
Contributor
Author
|
@elasticmachine merge upstream |
wylieconlon
approved these changes
Feb 27, 2020
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
LGTM, tested locally
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Mar 2, 2020
ppisljar
added a commit
that referenced
this pull request
Mar 2, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2020
* master: (26 commits) [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627) Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876) [Maps] direct Discover "visualize" to open Maps application (elastic#58549) Disallow duplicate percentiles (elastic#57444) (elastic#58299) removing references to visTypes uiExports (elastic#58337) [SIEM] Default the Timeline events filter to show All events (elastic#58953) [Remote clusters] Add indexManagement as required plugin (elastic#58915) [DOCS] Rework of main get started page (elastic#58260) [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348) [Endpoint] add resolver middleware (elastic#58288) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removes remaining references to visTypes uiExports (and related)
partly resolves #50897