Disallow duplicate percentiles (#57444)#58299
Merged
ThomThomson merged 13 commits intoelastic:masterfrom Mar 2, 2020
Merged
Conversation
…allow duplicates. Enabled this option in the percentiles editor. Added unit / integration tests
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
nickofthyme
reviewed
Feb 24, 2020
...plugins/vis_default_editor/public/components/controls/components/number_list/number_list.tsx
Outdated
Show resolved
Hide resolved
nickofthyme
reviewed
Feb 24, 2020
...y/core_plugins/vis_default_editor/public/components/controls/components/number_list/utils.ts
Outdated
Show resolved
Hide resolved
…method, updated tests to reflect change. Made Validate Ascending order default to false, and updated it to match in Percentiles and Percentile_ranks
…uplicatePercentile
gchaps
reviewed
Feb 26, 2020
...y/core_plugins/vis_default_editor/public/components/controls/components/number_list/utils.ts
Outdated
Show resolved
Hide resolved
...plugins/vis_default_editor/public/components/controls/components/number_list/number_list.tsx
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
timroes
approved these changes
Mar 2, 2020
Contributor
timroes
left a comment
There was a problem hiding this comment.
Tested on Chrome Linux, works. Code LGTM
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2020
* master: (26 commits) [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627) Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876) [Maps] direct Discover "visualize" to open Maps application (elastic#58549) Disallow duplicate percentiles (elastic#57444) (elastic#58299) removing references to visTypes uiExports (elastic#58337) [SIEM] Default the Timeline events filter to show All events (elastic#58953) [Remote clusters] Add indexManagement as required plugin (elastic#58915) [DOCS] Rework of main get started page (elastic#58260) [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348) [Endpoint] add resolver middleware (elastic#58288) ...
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
ThomThomson
added a commit
that referenced
this pull request
Mar 5, 2020
Added an optional validation step to the number_list component to disallow duplicates, Reworked and consolidated number_list component validations into one method and enabled this option in the percentiles editor. Added unit / integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added an option for disallowing duplicates in the number list component. Enabled this option in the percentiles editor. Closes #57444.
Checklist
Delete any items that are not applicable to this PR.
For maintainers