[Maps] direct Discover "visualize" to open Maps application#58549
Merged
nreese merged 14 commits intoelastic:masterfrom Mar 2, 2020
Merged
[Maps] direct Discover "visualize" to open Maps application#58549nreese merged 14 commits intoelastic:masterfrom
nreese merged 14 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
jsanz
approved these changes
Feb 26, 2020
Contributor
jsanz
left a comment
There was a problem hiding this comment.
tested locally in Chromium and Firefox, for both geo_point and geo_shape types, the automatic tooltip based on the columns configured from the Discover app was a nice surprise 😄
Contributor
Author
|
@elasticmachine merge upstream |
kertal
reviewed
Feb 28, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
This is nice improvement for the user! 👍 Added some code remarks to discuss. Do you think it makes sense also to use 'Maps' instead of 'Visualize' as text in the link?
...egacy/core_plugins/kibana/public/discover/np_ready/components/field_chooser/field_chooser.js
Outdated
Show resolved
Hide resolved
...egacy/core_plugins/kibana/public/discover/np_ready/components/field_chooser/field_chooser.js
Outdated
Show resolved
Hide resolved
Contributor
Author
I don't think that would add any value. Since the page is angular and going to be refactored in the future I don't think tinkering with small details like this is worth the effort. |
kertal
approved these changes
Feb 28, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally in Chrome, nice improvement for the user!
timroes
reviewed
Mar 2, 2020
...egacy/core_plugins/kibana/public/discover/np_ready/components/field_chooser/field_chooser.js
Outdated
Show resolved
Hide resolved
timroes
reviewed
Mar 2, 2020
..._plugins/kibana/public/discover/np_ready/components/field_chooser/lib/visualize_url_utils.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 2, 2020
…58549) * [Maps] direct Discover visualize to Maps application * pass initial layers to maps app * add functional test * fix parentheses messed up by lint fix * fix i18n expression * move logic into lib * fix typescript errors * use constant for geo_point and geo_shape, more TS noise * use encode_array in an attempt to make TS happy * another round of TS changes * one more thing Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Mar 2, 2020
…59066) * [Maps] direct Discover visualize to Maps application * pass initial layers to maps app * add functional test * fix parentheses messed up by lint fix * fix i18n expression * move logic into lib * fix typescript errors * use constant for geo_point and geo_shape, more TS noise * use encode_array in an attempt to make TS happy * another round of TS changes * one more thing Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2020
* master: (26 commits) [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627) Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876) [Maps] direct Discover "visualize" to open Maps application (elastic#58549) Disallow duplicate percentiles (elastic#57444) (elastic#58299) removing references to visTypes uiExports (elastic#58337) [SIEM] Default the Timeline events filter to show All events (elastic#58953) [Remote clusters] Add indexManagement as required plugin (elastic#58915) [DOCS] Rework of main get started page (elastic#58260) [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348) [Endpoint] add resolver middleware (elastic#58288) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #57051
This PR updates Discover to open geo_point and geo_shape fields in the Maps application when the Maps app is available.
To handle the link, the maps application has a new parameter,
initialLayers, that can be used to pass layer descriptors to a new map instance.I was going to wait for #57879 to merge prior to making this change but, that PR may not make 7.7 and I wanted to make sure Discover points users towards the maps application instead of the legacy map visualizations. Then once #57879 is merged, the layer descriptor can be updated to use the blended layer.