[Endpoint] [Tests] fixes #57946 flaky endpoint policy list test by charlie-pichette · Pull Request #58348 · elastic/kibana

charlie-pichette · 2020-02-24T14:30:04Z

Summary

The endpoint policy list tests were flaky. Added a function to wait for the table data to populate before check the details.

Checklist

Delete any items that are not applicable to this PR.

~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~
~~This renders correctly on smaller devices using a responsive layout. (You can test this in your browser~~
~~This was checked for cross-browser compatibility, including a check against IE11~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~

fix location of es archive file

elasticmachine · 2020-02-24T14:30:07Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-02-24T14:30:09Z

Pinging @elastic/endpoint-response (Team:Endpoint Response)

elasticmachine · 2020-02-24T14:30:12Z

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

elasticmachine · 2020-02-24T14:30:14Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

x-pack/test/functional/apps/endpoint/policy_list.ts

EricDavisX

looks good to me then, thanks guys for the comment and the fix.

aisantos

looks good to me. I added a comment and nit

aisantos · 2020-02-24T17:10:51Z

x-pack/test/functional/page_objects/endpoint_page.ts

@@ -58,5 +59,13 @@ export function EndpointPageProvider({ getService }: FtrProviderContext) {
            )
        );
    },


I used the Cheerio service to pull data from a table in my pagination test. I had to use this in conjunction with dataTestSubjects. 👍

aisantos · 2020-02-24T17:17:23Z

x-pack/test/functional/page_objects/endpoint_page.ts

+      await retry.waitForWithTimeout('table to have data', 2000, async () => {
+        const tableData = await this.getEndpointAppTableData(dataTestSubj);
+        if (tableData[1][0] === 'No items found') return false;
+        return true;


Nit - I'm wondering if the 'No items found' will always be in that part of the table.

Yes, it is always part of the endpoint management tables.

charlie-pichette · 2020-02-24T19:57:49Z

@elasticmachine merge upstream

…-test

charlie-pichette · 2020-03-02T13:21:55Z

@elasticmachine merge upstream

…-test

kibanamachine · 2020-03-02T15:11:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 420d289

History

💔 Build #28456 failed 43e9f34

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (26 commits) [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627) Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876) [Maps] direct Discover "visualize" to open Maps application (elastic#58549) Disallow duplicate percentiles (elastic#57444) (elastic#58299) removing references to visTypes uiExports (elastic#58337) [SIEM] Default the Timeline events filter to show All events (elastic#58953) [Remote clusters] Add indexManagement as required plugin (elastic#58915) [DOCS] Rework of main get started page (elastic#58260) [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348) [Endpoint] add resolver middleware (elastic#58288) ...

kibanamachine · 2020-03-03T15:48:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58348 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-03-04T15:58:44Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…) (#59158) * endpoint-161-refactor-management-list-test * fix location of es archive file * issue 57946 fix flaky endpoint policy list test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

charlie-pichette and others added 10 commits February 20, 2020 11:39

endpoint-161-refactor-management-list-test

bd64187

Merge branch 'master' into endpoint-list-ui-tests

3d5f573

Merge branch 'master' into endpoint-list-ui-tests

f1142b4

Merge branch 'charlie-pichette-endpoint-list-ui-tests'

16bf753

Merge remote-tracking branch 'upstream/master'

5a62211

fix location of es archive file

6e1c87f

Merge remote-tracking branch 'upstream/master'

e23f779

Merge pull request #1 from charlie-pichette/endpoint-list-ui-tests

e54ce10

fix location of es archive file

Merge remote-tracking branch 'upstream/master'

345bf1f

issue 57946 fix flaky endpoint policy list test

43e9f34

charlie-pichette added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:Endpoint Response Endpoint Response Team Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature labels Feb 24, 2020

paul-tavares approved these changes Feb 24, 2020

View reviewed changes

charlie-pichette changed the title ~~[Endpoint] [Tests] Issue 57946 fix flaky endpoint policy list test~~ [Endpoint] [Tests] fixes #58348 flaky endpoint policy list test Feb 24, 2020

charlie-pichette changed the title ~~[Endpoint] [Tests] fixes #58348 flaky endpoint policy list test~~ [Endpoint] [Tests] fixes #57946 flaky endpoint policy list test Feb 24, 2020

EricDavisX reviewed Feb 24, 2020

View reviewed changes

x-pack/test/functional/apps/endpoint/policy_list.ts Show resolved Hide resolved

EricDavisX approved these changes Feb 24, 2020

View reviewed changes

aisantos approved these changes Feb 24, 2020

View reviewed changes

Merge branch 'master' into issue-57946-fix-flaky-endpoint-policy-list…

3eb6ffb

…-test

Merge branch 'master' into issue-57946-fix-flaky-endpoint-policy-list…

420d289

…-test

charlie-pichette merged commit 74d0e92 into elastic:master Mar 2, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 3, 2020

charlie-pichette mentioned this pull request Mar 3, 2020

[7.x] [Endpoint] [Tests] fixes #57946 flaky endpoint policy list test (#58348) #59158

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 4, 2020

charlie-pichette added v7.8 and removed v7.7.0 labels Mar 27, 2020

rayafratkina added v7.8.0 and removed v7.8 labels Apr 6, 2020

Conversation

charlie-pichette commented Feb 24, 2020

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 24, 2020

Uh oh!

elasticmachine commented Feb 24, 2020

Uh oh!

elasticmachine commented Feb 24, 2020

Uh oh!

elasticmachine commented Feb 24, 2020

Uh oh!

Uh oh!

EricDavisX left a comment

Choose a reason for hiding this comment

Uh oh!

aisantos left a comment

Choose a reason for hiding this comment

Uh oh!

aisantos Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

aisantos Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

charlie-pichette Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

charlie-pichette commented Feb 24, 2020

Uh oh!

charlie-pichette commented Mar 2, 2020

Uh oh!

kibanamachine commented Mar 2, 2020

💚 Build Succeeded

History

Uh oh!

kibanamachine commented Mar 3, 2020

Uh oh!

kibanamachine commented Mar 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants