[Console] Floating tooltip needs to take page offset into account#54567
Merged
jloleysens merged 2 commits intoelastic:masterfrom Jan 14, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
…age-offset-floating-tooltip * 'master' of github.com:elastic/kibana: [Maps] refactor isPointsOnly, isLinesOnly, and isPolygonsOnly to make synchronous (elastic#54067) Fix icon path in tutorial introduction (elastic#49684) [State Management] State containers improvements (elastic#54436) Fix floating tools rendering logic (elastic#54505) Handle another double quote special case (elastic#54474) [Home][Tutorial] Add data UI for IBM MQ Filebeat module (elastic#54238) fix(package): upgrade transitive dependency elliptic to v6.5.2 (elastic#54476) [Graph] Fix various a11y issues (elastic#54097) # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/legacy_core_editor.ts
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
Jan 13, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Tested locally on Chrome. Thanks for tracking this down!
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 14, 2020
* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 14, 2020
jloleysens
added a commit
that referenced
this pull request
Jan 14, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Floating tooltips do not take page offset into consideration.
Whenever it is possible to scroll in Console the page offset needs to be taken into consideration in order to render tooltips in the correct position.
It looks like
pageYOffsetis what we need to fix this: https://caniuse.com/#search=pageYOffsetNotes
This regression was introduced probably after merging #52270. Before the Console window would not overflow.This was introduced with
calc(100vh - calc(#{$euiHeaderChildSize} * 2))for calculating the height of the console container insidesrc/legacy/core_plugins/console/public/np_ready/application/styles/_app.scss. (#51707)Todo