[Console] Fix floating tools rendering logic#54505
Merged
jloleysens merged 2 commits intoelastic:masterfrom Jan 13, 2020
Merged
[Console] Fix floating tools rendering logic#54505jloleysens merged 2 commits intoelastic:masterfrom
jloleysens merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Jan 11, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Tested locally and did not spot any issues.
| // from pageY to get the new top value | ||
| const offsetFromPage = $(this.editor.container).offset()!.top; | ||
| const startRow = range.start.lineNumber - 1; | ||
| const startLine = range.start.lineNumber; |
Contributor
There was a problem hiding this comment.
nit: at first glance, i don't think the const name startLine is clear in how it differs from firstLine
Contributor
Author
There was a problem hiding this comment.
After this #52270 was merged a distinction was created between row (zero indexed) and line (not-zero indexed). This was informed by the approach taken by Monaco 😅
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 13, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 13, 2020
…age-offset-floating-tooltip * 'master' of github.com:elastic/kibana: [Maps] refactor isPointsOnly, isLinesOnly, and isPolygonsOnly to make synchronous (elastic#54067) Fix icon path in tutorial introduction (elastic#49684) [State Management] State containers improvements (elastic#54436) Fix floating tools rendering logic (elastic#54505) Handle another double quote special case (elastic#54474) [Home][Tutorial] Add data UI for IBM MQ Filebeat module (elastic#54238) fix(package): upgrade transitive dependency elliptic to v6.5.2 (elastic#54476) [Graph] Fix various a11y issues (elastic#54097) # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/legacy_core_editor.ts
jloleysens
added a commit
that referenced
this pull request
Jan 13, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #52270 was merged, a regression snuck in that made the floating tools rendering on screen width changes break.
Additionally I managed to get an infinite loop going fairly consistently at one point by resizing this text (which I have been struggling to repro):
How to review
Try and break the resizing behaviour using the resizer in Console. Specifically dragging to the left and squishing any text that is there. Look out for any weird behaviour.