Fix icon path in tutorial introduction#49684
Merged
jsoriano merged 6 commits intoelastic:masterfrom Jan 13, 2020
jsoriano:fix-tutorial-icons-svg
Merged
Fix icon path in tutorial introduction#49684jsoriano merged 6 commits intoelastic:masterfrom jsoriano:fix-tutorial-icons-svg
jsoriano merged 6 commits intoelastic:masterfrom
jsoriano:fix-tutorial-icons-svg
Conversation
Contributor
💚 Build Succeeded
|
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed
|
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
|
Some icons are included as SVG files with relative paths to their location. Add the base path so these files are correctly displayed when Kibana is not running from the root path.
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
timroes
reviewed
Jan 13, 2020
src/legacy/core_plugins/kibana/public/home/np_ready/components/tutorial/tutorial.js
Outdated
Show resolved
Hide resolved
timroes
approved these changes
Jan 13, 2020
Contributor
timroes
left a comment
There was a problem hiding this comment.
Tested on Chrome Linux, code LGTM
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 13, 2020
…age-offset-floating-tooltip * 'master' of github.com:elastic/kibana: [Maps] refactor isPointsOnly, isLinesOnly, and isPolygonsOnly to make synchronous (elastic#54067) Fix icon path in tutorial introduction (elastic#49684) [State Management] State containers improvements (elastic#54436) Fix floating tools rendering logic (elastic#54505) Handle another double quote special case (elastic#54474) [Home][Tutorial] Add data UI for IBM MQ Filebeat module (elastic#54238) fix(package): upgrade transitive dependency elliptic to v6.5.2 (elastic#54476) [Graph] Fix various a11y issues (elastic#54097) # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/legacy_core_editor.ts
jsoriano
added a commit
that referenced
this pull request
Jan 13, 2020
jsoriano
added a commit
that referenced
this pull request
Jan 14, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
Some icons are included as SVG files with relative paths to their location. Add the base path so these files are correctly displayed when Kibana is not running from the root path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some icons are included as SVG files with relative paths to their
location. Add the base path so these files are correctly displayed when
Kibana is not running from the root path.
Summary
Icons are not being displayed when defined as a path:
With this change:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for [keyboard-only and screenreader accessibility]¡(https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)For maintainers