Support "Deprecated" label in advanced settings#54539
Merged
lizozom merged 14 commits intoelastic:masterfrom Jan 13, 2020
Merged
Support "Deprecated" label in advanced settings#54539lizozom merged 14 commits intoelastic:masterfrom
lizozom merged 14 commits intoelastic:masterfrom
Conversation
mark courier:batchSearches as deprecated
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@elasticmachine merge upstream |
added 2 commits
January 12, 2020 13:41
d719885 to
421981d
Compare
Dosant
approved these changes
Jan 13, 2020
src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@stacey-gammon @lukasolson What do you think? |
…/deprecation-label
mshustov
reviewed
Jan 13, 2020
|
This is great! |
cchaos
reviewed
Jan 13, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
The UI LGTM. I saw just a couple things in the code and as mentioned, this still needs a deprecation statement in the docs.
src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
Outdated
Show resolved
Hide resolved
Translate click aria label Use docLinks service
mshustov
approved these changes
Jan 13, 2020
cchaos
approved these changes
Jan 13, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
👍 on the UI. Will you be adding the deprecation warning in the docs in this PR?
…/deprecation-label
Contributor
Author
added 5 commits
January 13, 2020 19:29
This reverts commit c9512ce.
…/deprecation-label
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jan 13, 2020
* Support deprecating label in advanced settings mark courier:batchSearches as deprecated * jest update * Add deprecation to UiSettingsParams type Translate click aria label Use docLinks service * Rename doc link * Remove url option from DeprecationSettings * Simplify code * Updated docs * Revert "Updated docs" This reverts commit c9512ce. * snapshots * docs
lizozom
pushed a commit
that referenced
this pull request
Jan 13, 2020
* Support deprecating label in advanced settings mark courier:batchSearches as deprecated * jest update * Add deprecation to UiSettingsParams type Translate click aria label Use docLinks service * Rename doc link * Remove url option from DeprecationSettings * Simplify code * Updated docs * Revert "Updated docs" This reverts commit c9512ce. * snapshots * docs
pgayvallet
reviewed
Jan 14, 2020
Comment on lines
+1931
to
+1932
| // Warning: (ae-forgotten-export) The symbol "DeprecationSettings" needs to be exported by the entry point index.d.ts | ||
| deprecation?: DeprecationSettings; |
Contributor
There was a problem hiding this comment.
Minor, but DeprecationSettings should be exported
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 14, 2020
* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* Support deprecating label in advanced settings mark courier:batchSearches as deprecated * jest update * Add deprecation to UiSettingsParams type Translate click aria label Use docLinks service * Rename doc link * Remove url option from DeprecationSettings * Simplify code * Updated docs * Revert "Updated docs" This reverts commit c9512ce. * snapshots * docs
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
courier:batchSearchesas deprecatedChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Unit or functional tests were updated or added to match the most common scenariosFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately