Export new ui settings types and regenerate docs#55020
Merged
lizozom merged 2 commits intoelastic:masterfrom Jan 16, 2020
Merged
Export new ui settings types and regenerate docs#55020lizozom merged 2 commits intoelastic:masterfrom
lizozom merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@elasticmachine merge upstream |
7 tasks
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Jan 16, 2020
Comment on lines
+219
to
+221
| ImageValidation, | ||
| DeprecationSettings, | ||
| StringValidation, |
Contributor
There was a problem hiding this comment.
Ideally now that these are public, and as they are very generic name with very specific usages, they should start with the UiSettings prefix to avoid conflicts.
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jan 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom
pushed a commit
that referenced
this pull request
Jan 16, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export new ui settings types and regenerate docs
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers