[SIEM] Use bulk actions API when updating or deleting rules by spong · Pull Request #54521 · elastic/kibana

spong · 2020-01-11T01:18:52Z

Summary

This PR updates the All Rules Table actions to use the new bulk API introduced in #53543. More robust error reporting has also been added to let the user know exactly which operation has failed. Note that individual update/delete requests now also go through the bulk API as this simplifies the implementation and error handling.

Additional features:

Adds toast error when failing to activate, deactivate or delete a rule (related [SIEM] Error Toasts incorrectly displaying in bottom left of page #54515)
Extracted commonly used toast utility for better re-use
Removes ability to delete immutable rules

Activate/Deactivate Before:

(Ignore failed requests from test env -- request count is important here)

Activate/Deactivate After:

Delete Before:

(Ignore failed requests from test env -- request count is important here)

Delete After:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

…ctions

elasticmachine · 2020-01-11T01:18:54Z

Pinging @elastic/siem (Team:SIEM)

FrankHassanabad · 2020-01-13T20:49:24Z

x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/all/__mocks__/mock.ts

+    },
+    tags: [],
+  },
+];


FrankHassanabad · 2020-01-13T20:50:54Z

x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/all/helpers.test.tsx

+      });
+    });
+  });
+});


Thanks for the tests! 👍

FrankHassanabad · 2020-01-13T20:52:50Z

x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/translations.ts

+export const DUPLICATE_RULE_ERROR = i18n.translate(
+  'xpack.siem.detectionEngine.rules.allRules.actions.duplicateRuleErrorDescription',
+  {
+    defaultMessage: 'Error duplicating rule…',


You want to use ellipses or three dots?

If so just to let you know we have these other two that aren't?

Design has been having them as ellipses iirc, so I've been following that convention. @MichaelMarcialis, can you confirm which we should be conforming too?

Great question. I'd prefer our usage be of a horizontal ellipsis (… or …) going forward.

Perfect -- thanks @MichaelMarcialis! I've created #54677 for tracking so it doesn't get lost in the shuffle! 🙂

…ctions

FrankHassanabad

Checked it out and tested it and everything works as expected.

Really fast changes for this appreciate it!

…ctions

kibanamachine · 2020-01-13T22:20:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4fab09e

History

💚 Build #19488 succeeded df4584e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…54521) ## Summary This PR updates the `All Rules Table` actions to use the new bulk API introduced in elastic#53543. More robust error reporting has also been added to let the user know exactly which operation has failed. Note that individual `update`/`delete` requests now also go through the bulk API as this simplifies the implementation and error handling. Additional features: * Adds toast error when failing to activate, deactivate or delete a rule (related elastic#54515) * Extracted commonly used toast utility for better re-use * Removes ability to delete `immutable` rules ##### Activate/Deactivate Before: ![bulk_activate_before](https://user-images.githubusercontent.com/2946766/72196245-0ea50300-33d4-11ea-8d49-5ebdb63db1a1.gif) (Ignore failed requests from test env -- request count is important here) ##### Activate/Deactivate After: ![bulk_activate_after](https://user-images.githubusercontent.com/2946766/72196361-c0443400-33d4-11ea-9a42-11f66c64e925.gif) ##### Delete Before: ![bulk_delete_before](https://user-images.githubusercontent.com/2946766/72196249-149ae400-33d4-11ea-80fc-b2f7fb83245f.gif) (Ignore failed requests from test env -- request count is important here) ##### Delete After: ![bulk_delete_after](https://user-images.githubusercontent.com/2946766/72196366-c803d880-33d4-11ea-90d8-f1917b18035f.gif) ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

…54663) ## Summary This PR updates the `All Rules Table` actions to use the new bulk API introduced in #53543. More robust error reporting has also been added to let the user know exactly which operation has failed. Note that individual `update`/`delete` requests now also go through the bulk API as this simplifies the implementation and error handling. Additional features: * Adds toast error when failing to activate, deactivate or delete a rule (related #54515) * Extracted commonly used toast utility for better re-use * Removes ability to delete `immutable` rules ##### Activate/Deactivate Before: ![bulk_activate_before](https://user-images.githubusercontent.com/2946766/72196245-0ea50300-33d4-11ea-8d49-5ebdb63db1a1.gif) (Ignore failed requests from test env -- request count is important here) ##### Activate/Deactivate After: ![bulk_activate_after](https://user-images.githubusercontent.com/2946766/72196361-c0443400-33d4-11ea-9a42-11f66c64e925.gif) ##### Delete Before: ![bulk_delete_before](https://user-images.githubusercontent.com/2946766/72196249-149ae400-33d4-11ea-80fc-b2f7fb83245f.gif) (Ignore failed requests from test env -- request count is important here) ##### Delete After: ![bulk_delete_after](https://user-images.githubusercontent.com/2946766/72196366-c803d880-33d4-11ea-90d8-f1917b18035f.gif) ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...

…54521) ## Summary This PR updates the `All Rules Table` actions to use the new bulk API introduced in elastic#53543. More robust error reporting has also been added to let the user know exactly which operation has failed. Note that individual `update`/`delete` requests now also go through the bulk API as this simplifies the implementation and error handling. Additional features: * Adds toast error when failing to activate, deactivate or delete a rule (related elastic#54515) * Extracted commonly used toast utility for better re-use * Removes ability to delete `immutable` rules ##### Activate/Deactivate Before: ![bulk_activate_before](https://user-images.githubusercontent.com/2946766/72196245-0ea50300-33d4-11ea-8d49-5ebdb63db1a1.gif) (Ignore failed requests from test env -- request count is important here) ##### Activate/Deactivate After: ![bulk_activate_after](https://user-images.githubusercontent.com/2946766/72196361-c0443400-33d4-11ea-9a42-11f66c64e925.gif) ##### Delete Before: ![bulk_delete_before](https://user-images.githubusercontent.com/2946766/72196249-149ae400-33d4-11ea-80fc-b2f7fb83245f.gif) (Ignore failed requests from test env -- request count is important here) ##### Delete After: ![bulk_delete_after](https://user-images.githubusercontent.com/2946766/72196366-c803d880-33d4-11ea-90d8-f1917b18035f.gif) ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

spong added 2 commits January 10, 2020 17:52

Migrates actions to use new bulk API

472d04a

Merge branch 'master' of github.com:elastic/kibana into rules-batch-a…

df4584e

…ctions

spong added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 11, 2020

spong requested review from FrankHassanabad and XavierM January 11, 2020 01:18

spong self-assigned this Jan 11, 2020

FrankHassanabad reviewed Jan 13, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into rules-batch-a…

1fe6a19

…ctions

FrankHassanabad approved these changes Jan 13, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into rules-batch-a…

4fab09e

…ctions

spong merged commit 6f54c06 into elastic:master Jan 13, 2020

spong deleted the rules-batch-actions branch January 13, 2020 22:25

spong mentioned this pull request Jan 13, 2020

[7.x] [SIEM] Use bulk actions API when updating or deleting rules (#54521) #54663

Merged

spong mentioned this pull request Jan 14, 2020

[SIEM] Standardize usage of ellipses to horizontal ellipses #54677

Open

spong mentioned this pull request Feb 11, 2020

[SIEM][Detection Engine] Backend end-to-end tests #57166

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Use bulk actions API when updating or deleting rules#54521

[SIEM] Use bulk actions API when updating or deleting rules#54521
spong merged 4 commits intoelastic:masterfrom
spong:rules-batch-actions

spong commented Jan 11, 2020

Uh oh!

elasticmachine commented Jan 11, 2020

Uh oh!

FrankHassanabad Jan 13, 2020

Uh oh!

FrankHassanabad Jan 13, 2020

Uh oh!

FrankHassanabad Jan 13, 2020

Uh oh!

spong Jan 13, 2020

Uh oh!

MichaelMarcialis Jan 13, 2020

Uh oh!

spong Jan 14, 2020

Uh oh!

FrankHassanabad left a comment

Uh oh!

kibanamachine commented Jan 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

spong commented Jan 11, 2020

Summary

Activate/Deactivate Before:

Activate/Deactivate After:

Delete Before:

Delete After:

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 11, 2020

Uh oh!

FrankHassanabad Jan 13, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jan 13, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jan 13, 2020

Choose a reason for hiding this comment

Uh oh!

spong Jan 13, 2020

Choose a reason for hiding this comment

Uh oh!

MichaelMarcialis Jan 13, 2020

Choose a reason for hiding this comment

Uh oh!

spong Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 13, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants