[ML] Model memory limit calculator enhancements for multi-metric job wizard #54573
Merged
darnautov merged 2 commits intoelastic:masterfrom Jan 14, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
| useEffect(() => { | ||
| jobCreator.removeAllInfluencers(); | ||
| influencers.forEach(i => jobCreator.addInfluencer(i)); | ||
| if (jobCreator instanceof MultiMetricJobCreator) { |
Member
There was a problem hiding this comment.
it's worth noting here that there is a isMultiMetricJobCreator type guard function that is typically used in the job wizards for checks like this.
But using instanceof is just as good.
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 14, 2020
…#54573) * [ML] fix fieldNames provided to calculateModelMemoryLimit * [ML] calculateModelMemoryLimit when the influencers are changed
darnautov
added a commit
that referenced
this pull request
Jan 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 14, 2020
* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...
6 tasks
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
…#54573) * [ML] fix fieldNames provided to calculateModelMemoryLimit * [ML] calculateModelMemoryLimit when the influencers are changed
Contributor
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #54441.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorials