[SIEM] show getting started page on empty string or _all#47166
Merged
stephmilovic merged 1 commit intoelastic:masterfrom Oct 3, 2019
Merged
[SIEM] show getting started page on empty string or _all#47166stephmilovic merged 1 commit intoelastic:masterfrom
stephmilovic merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build Succeeded |
spong
approved these changes
Oct 2, 2019
Member
spong
left a comment
There was a problem hiding this comment.
Checked out, tested locally and getting started page is shown when siem:defaultIndex is either emptystring or _all. LGTM 👍
As a note, with this implementation you can still query all indices by using an index pattern like ,,, as this will bypass the length check. I don't think it's really necessary to switch the impl to check if args.defaultIndex contains either emptystring or _all as the intent here is really just to show the getting started page if the user accidentally clears out all of their indices. We can revisit validation of siem:defaultIndex if this becomes an issue.
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Oct 3, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
stephmilovic
added a commit
that referenced
this pull request
Oct 8, 2019
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #46091
As decided in the discussion of the issue linked above, if the user either leaves the siem:defaultIndex option blank (empty string) or if they set it to
_allwe do not query anything but rather show the getting started page:Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately