[Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances#46381
Merged
kindsun merged 9 commits intoelastic:masterfrom Oct 2, 2019
Conversation
Contributor
|
Pinging @elastic/kibana-gis |
8 tasks
nreese
reviewed
Sep 23, 2019
Contributor
nreese
left a comment
There was a problem hiding this comment.
Nice start. I think this concept could also be used by embeddables. For example APM, just wanted to pass geojson directly into Maps instead of having Maps fetch its own data.
How about renaming pushedData? Maybe cannedData or staticData or injectedData or inlineData? The work "pushed" is a little vague.
x-pack/legacy/plugins/maps/public/layers/sources/client_file_source/geojson_file_source.js
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
added 4 commits
September 26, 2019 09:28
…n-geojson-descriptor
…n-geojson-descriptor
Contributor
💔 Build Failed |
added 3 commits
October 2, 2019 10:00
nreese
reviewed
Oct 2, 2019
nreese
approved these changes
Oct 2, 2019
Contributor
nreese
left a comment
There was a problem hiding this comment.
lgtm with green CI
code review, tested in Chrome
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Oct 2, 2019
…e assigned to new InjectedData instances (elastic#46381) * Add 'PushedData' class and revise so data is assigned to new instances * Update 'pushedData' refs to 'injectedData' * Set default visibility to true on injected data * Review feedback * Update tests to account for injectedData * Review feedback
kindsun
pushed a commit
that referenced
this pull request
Oct 3, 2019
…e assigned to new InjectedData instances (#46381) (#47158) * Add 'PushedData' class and revise so data is assigned to new instances * Update 'pushedData' refs to 'injectedData' * Set default visibility to true on injected data * Review feedback * Update tests to account for injectedData * Review feedback
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the entire parsed GeoJSON object was assigned to the
layerDescriptorobject. This issue wasn't apparent until attempting a fix for #40205 and getting OOM errors on files of higher size. Specifically, the application would crash when copying the descriptor object inmap_selectors > hasDirtyState() > copyPersistentState. The best way to test this fix currently is to set the following breakpoint:and inspect the
layerDescriptorobject passed to the function. Previously, thelayerDescriptor > sourceDescriptorcontained the feature collection, now the feature collection is stored inlayerDescriptor > __pushedDatawhich isn't copied here, preventing any potential errors.The process used is highly similar to that used for
DataRequestshowever this data is different in that it's "pushed" to us upfront by the File Upload plugin.